You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/25 15:46:43 UTC

[GitHub] [shardingsphere] terrymanu opened a new issue, #18591: Add test cases of InstanceDefinition

terrymanu opened a new issue, #18591:
URL: https://github.com/apache/shardingsphere/issues/18591

   The method to be tested:
   
   - [ ] getAttributes
   - [ ] getIp
   - [ ] getUniqueSign


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on issue #18591: Add test cases of InstanceMetaData

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #18591:
URL: https://github.com/apache/shardingsphere/issues/18591#issuecomment-1174583696

   Hi, the class is renamed to InstanceMetaData which is an interface, and the test cases are completed. So I just close the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed issue #18591: Add test cases of InstanceMetaData

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #18591: Add test cases of InstanceMetaData
URL: https://github.com/apache/shardingsphere/issues/18591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kvaithin commented on issue #18591: Add test cases of InstanceDefinition

Posted by GitBox <gi...@apache.org>.
kvaithin commented on issue #18591:
URL: https://github.com/apache/shardingsphere/issues/18591#issuecomment-1166383587

   Hi, did not reset the counter as suggested. As it comes into play only in one of the tests and not affecting others. 
   Avoided it as would have had to use meddle with reflection to reset it considering the `ATOMIC_LONG` value is private.
   
   Please do advice if the counter reset is a must. And if so if we are open to making `ATOMIC_LONG` package private in that case to ease the reset. Thanks. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kvaithin commented on issue #18591: Add test cases of InstanceDefinition

Posted by GitBox <gi...@apache.org>.
kvaithin commented on issue #18591:
URL: https://github.com/apache/shardingsphere/issues/18591#issuecomment-1166379875

   Hi could I pick this up pls. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org