[GitHub] mistercrunch commented on a change in pull request #4436: Pass in cache timeout for async queries

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4436: Pass in cache timeout for async queries
URL: https://github.com/apache/incubator-superset/pull/4436#discussion_r168660467
 
 

 ##########
 File path: superset/sql_lab.py
 ##########
 @@ -272,7 +272,10 @@ def handle_error(msg):
         key = '{}'.format(uuid.uuid4())
         logging.info('Storing results in results backend, key: {}'.format(key))
         json_payload = json.dumps(payload, default=utils.json_iso_dttm_ser)
-        results_backend.set(key, utils.zlib_compress(json_payload))
+        cache_timeout = database.cache_timeout
+        if cache_timeout is None:
+            cache_timeout = config.get('CACHE_DEFAULT_TIMEOUT', 0)
+        results_backend.set(key, utils.zlib_compress(json_payload), cache_timeout)
 
 Review comment:
   Oh interesting. FYI we use the s3 caching as a result backend which doesn't really support timeout, so this won't matter on our end, but for people using other results backend that's probably the desired behavior. https://github.com/bkyryliuk/s3werkzeugcache/blob/master/s3cache/s3cache.py

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services