You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Koji Sekiguchi (JIRA)" <ji...@apache.org> on 2009/01/01 07:18:44 UTC

[jira] Created: (SOLR-947) QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery

QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery
------------------------------------------------------------------------------

                 Key: SOLR-947
                 URL: https://issues.apache.org/jira/browse/SOLR-947
             Project: Solr
          Issue Type: Bug
          Components: search
    Affects Versions: 1.3
            Reporter: Koji Sekiguchi
            Assignee: Koji Sekiguchi
            Priority: Minor
             Fix For: 1.4


This

{code:title=QueryParsing.toString()}
if (query instanceof TermQuery) {
    :
} else if (query instanceof RangeQuery) {
    :
} else if (query instanceof ConstantScoreRangeQuery) {
    :
}
:
{code}

should be

{code:title=QueryParsing.toString()}
if (query instanceof TermQuery) {
    :
} else if (query instanceof ConstantScoreRangeQuery) {
	:
} else if (query instanceof RangeQuery) {
	:
}
:
{code}

This causes NPE when open ended range query (price:[1 TO *]) with debugQuery=on.

This is reported on the thread:
http://www.nabble.com/http-internal-error-if-i-enable-debugQuery%3Don-td21210570.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-947) QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660193#action_12660193 ] 

Yonik Seeley commented on SOLR-947:
-----------------------------------

Ah, this was introduced when Lucene changed ConstantScoreRangeQuery to inherit from RangeQuery.


> QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-947
>                 URL: https://issues.apache.org/jira/browse/SOLR-947
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-947.patch
>
>
> This
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof RangeQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
>     :
> }
> :
> {code}
> should be
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
> 	:
> } else if (query instanceof RangeQuery) {
> 	:
> }
> :
> {code}
> This causes NPE when open ended range query (price:[1 TO *]) with debugQuery=on.
> This is reported on the thread:
> http://www.nabble.com/http-internal-error-if-i-enable-debugQuery%3Don-td21210570.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-947) QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery

Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi resolved SOLR-947.
---------------------------------

    Resolution: Fixed

All tests pass. Committed revision 730514.

> QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-947
>                 URL: https://issues.apache.org/jira/browse/SOLR-947
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-947.patch
>
>
> This
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof RangeQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
>     :
> }
> :
> {code}
> should be
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
> 	:
> } else if (query instanceof RangeQuery) {
> 	:
> }
> :
> {code}
> This causes NPE when open ended range query (price:[1 TO *]) with debugQuery=on.
> This is reported on the thread:
> http://www.nabble.com/http-internal-error-if-i-enable-debugQuery%3Don-td21210570.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-947) QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery

Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi updated SOLR-947:
--------------------------------

    Attachment: SOLR-947.patch

I'll commit shortly.

> QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-947
>                 URL: https://issues.apache.org/jira/browse/SOLR-947
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-947.patch
>
>
> This
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof RangeQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
>     :
> }
> :
> {code}
> should be
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
> 	:
> } else if (query instanceof RangeQuery) {
> 	:
> }
> :
> {code}
> This causes NPE when open ended range query (price:[1 TO *]) with debugQuery=on.
> This is reported on the thread:
> http://www.nabble.com/http-internal-error-if-i-enable-debugQuery%3Don-td21210570.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-947) QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery

Posted by "Koji Sekiguchi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Koji Sekiguchi updated SOLR-947:
--------------------------------

    Affects Version/s:     (was: 1.3)
                       1.4

bq. Ah, this was introduced when Lucene changed ConstantScoreRangeQuery to inherit from RangeQuery.

Thanks Yonik for the input. I've changed affects version as 1.4 and removed the log from CHANGES.txt.

> QueryParsing.toString() should check ConstantScoreRangeQuery before RangeQuery
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-947
>                 URL: https://issues.apache.org/jira/browse/SOLR-947
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.4
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-947.patch
>
>
> This
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof RangeQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
>     :
> }
> :
> {code}
> should be
> {code:title=QueryParsing.toString()}
> if (query instanceof TermQuery) {
>     :
> } else if (query instanceof ConstantScoreRangeQuery) {
> 	:
> } else if (query instanceof RangeQuery) {
> 	:
> }
> :
> {code}
> This causes NPE when open ended range query (price:[1 TO *]) with debugQuery=on.
> This is reported on the thread:
> http://www.nabble.com/http-internal-error-if-i-enable-debugQuery%3Don-td21210570.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.