You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Paul Colby <pa...@colby.id.au> on 2011/03/29 10:14:33 UTC

Commit request for PHP binding

Hi all,

I'd love to get https://issues.apache.org/jira/browse/QPID-3027
committed, if that's possible.

I've created a review request https://reviews.apache.org/r/462/, but
no takers yet... ;)

Let me know if there's anything else I can do to try to shift it along... :)

Thanks :)

Paul.
----
http://colby.id.au

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: Commit request for PHP binding

Posted by Paul Colby <pa...@colby.id.au>.
On Wed, Mar 30, 2011 at 3:36 AM, Andrew Stitcher <as...@redhat.com> wrote:
> On Tue, 2011-03-29 at 19:14 +1100, Paul Colby wrote:
>> Hi all,
>>
>> I'd love to get https://issues.apache.org/jira/browse/QPID-3027
>> committed, if that's possible.
>>
>> I've created a review request https://reviews.apache.org/r/462/, but
>> no takers yet... ;)
>
> There's no actual diff to review attached to the reviewboard item.
> [That makes it harder to review :)]
>

doh!  I hadn't noticed the option to attach a diff in the review
board! (I'd just assumed that we're supposed to attach diffs to an
associated JIRA issue instead).

Fixed now :)

Thanks,

Paul.

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: Commit request for PHP binding

Posted by Andrew Stitcher <as...@redhat.com>.
On Tue, 2011-03-29 at 19:14 +1100, Paul Colby wrote:
> Hi all,
> 
> I'd love to get https://issues.apache.org/jira/browse/QPID-3027
> committed, if that's possible.
> 
> I've created a review request https://reviews.apache.org/r/462/, but
> no takers yet... ;)

There's no actual diff to review attached to the reviewboard item.
[That makes it harder to review :)]

Andrew



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org