You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/30 19:10:15 UTC
[GitHub] [incubator-nuttx] btashton opened a new pull request #1673: Docs: Update links to old website and wiki
btashton opened a new pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673
## Summary
Updates all the links to point at documentation at https://nuttx.apache.org/docs/latest or the new NuttX wiki.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#issuecomment-683465483
@v01d I think this addresses everything now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479811031
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
This is now fixed. I was careful to recover all the names correctly using entries in the git log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d merged pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d merged pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479805889
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
Please have a look here: https://nuttx.apache.org/docs/latest/contributing/documentation.html#linking
My intention was to not have to insert labels everywhere whenever we need to link to some section. So this could be done by linking as <pre>:ref:\`NSH </components/nsh/nsh.rst>`.</pre>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479811140
##########
File path: boards/README.txt
##########
@@ -228,8 +224,8 @@ boards/hc/m9s12/demo9s12ne64
is code complete but has not yet been verified.
boards/arm/tiva/dk-tm4c129x
- This is the port of NuttX to the Tiva� DK-TM4C129x Connected Development Kit. The
- Tiva� DK-TM4C129x features the TM4C129XNCZAD MCU.
+ This is the port of NuttX to the Tiva� DK-TM4C129x Connected Development Kit. The
Review comment:
A few strange characters appear here as well. Looks like (R) character.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479828488
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
@v01d @btashton If we switch autosection label off– we'll need to correct all the links in the current Supported Boards area (and everywhere else). I'm willing to help, let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479809490
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
Someone broke the unicode in the repo... I am fixing it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#issuecomment-683469331
> Ooof. This is one of those fixes where you try to do a little thing and it ends up in a bit of a rabbit hole.
> I made the style fixes to `kinetis_lowput.c` but it looks like the registers were never defined in the header only the offsets so there is a lot of uart_base+ going on in that C file unfortunately.
Sorry for that. Maybe in these cases we can ignore pre-existing style errors and leave them be for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479809410
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
before the rst links were to html which is also wrong. Can I leave this as is here or do you want me to rebase my work on top of yours?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806861
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
I think that if you save it as UTF-8 it should be OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479811934
##########
File path: boards/arm/lpc17xx_40xx/olimex-lpc1766stk/README.txt
##########
@@ -135,11 +135,11 @@ Olimex LPC1766-STK development board
LDS176 controller but it is 100% compatible with the Philips PCF8833).
So how do you tell which controller you have? Some message boards have
suggested that the LCD display be disassembled and the controller chip
- measured with a digital caliper � well that�s getting a bit extreme.
+ measured with a digital caliper � well that�s getting a bit extreme.
- "Here�s what I know. The Olimex boards have both display controllers
- possible; if the LCD has a GE-12 sticker on it, it�s a Philips PCF8833.
- If it has a GE-8 sticker, it�s an Epson controller. The older Sparkfun
+ "Here�s what I know. The Olimex boards have both display controllers
Review comment:
helps if I save all my open files... They are fixed but I have a lot of style violations now...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamfeuer commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
adamfeuer commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479828488
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
@v01d @btashton If we switch autosection label off– we'll need to correct all the links in the current Supported Boards area (and everywhere else). I'm wiling to help, let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479836530
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
Cool. I'll add a task to #1638 for it to remind us about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806253
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
I see strange characters here introduced, maybe an encoding problem of the file while saving.
##########
File path: ReleaseNotes
##########
@@ -5774,7 +5776,7 @@ Bugfixes (see the ChangeLog for details). Some of these are very important:
doing nothing! It turns out that that is not really important
because up_disable_irq() is not really used for that purpose. But
some spurions STM32 ADC interrupts have been reported to me and this
- turned out to be the cause in that case. Thanks to Manuel St�hn for
+ turned out to be the cause in that case. Thanks to Manuel St�hn for
Review comment:
again, encoding problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479809646
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
Yes, if we will switch autosectionlabel off they way you did it is the way it will be done in general.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#issuecomment-683458536
Note that this also updated a couple defconf that have `CONFIG_NSH_WGET_USERAGENT="NuttX/7.xx.x (; http://www.nuttx.org/)"` We should not be changing this in the example configs, it will always be out of date. The version is also hard coded in the Kconfig to an old version, but that is out of scope for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479811159
##########
File path: boards/arm/lpc17xx_40xx/olimex-lpc1766stk/README.txt
##########
@@ -135,11 +135,11 @@ Olimex LPC1766-STK development board
LDS176 controller but it is 100% compatible with the Philips PCF8833).
So how do you tell which controller you have? Some message boards have
suggested that the LCD display be disassembled and the controller chip
- measured with a digital caliper � well that�s getting a bit extreme.
+ measured with a digital caliper � well that�s getting a bit extreme.
- "Here�s what I know. The Olimex boards have both display controllers
- possible; if the LCD has a GE-12 sticker on it, it�s a Philips PCF8833.
- If it has a GE-8 sticker, it�s an Epson controller. The older Sparkfun
+ "Here�s what I know. The Olimex boards have both display controllers
Review comment:
Also here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806120
##########
File path: Documentation/reference/user/01_task_control.rst
##########
@@ -297,7 +297,7 @@ Functions
.. c:function:: void task_testcancel(void)
Creates a `Cancellation
- Point <http://www.nuttx.org/doku.php?id=wiki:nxinternal:cancellation-points>`__
+ Point <http://www.doku.php?id=wiki:nxinternal:cancellation-points>`__
Review comment:
something strange happened here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806075
##########
File path: Documentation/introduction/resources.rst
##########
@@ -9,7 +9,7 @@ Here's a list of Apache NuttX resources that you might find helpful:
* Apache NuttX
* `NuttX website <https://nuttx.apache.org>`_
- * `Apache NuttX website <https://www.nuttx.org>`_
+ * `Apache NuttX website <https://apache.nuttx.org>`_
* `Apache NuttX online documentation <https://cwiki.apache.org/confluence/display/NUTTX/Nuttx>`_
* `Apache NuttX mailing list <https://nuttx.incubator.apache.org/community/>`_ – a very active mailing list, the place to get help with your application or any questions you have about NuttX.
Review comment:
Note that `nuttx.incubator.apache.org` is used here. Maybe you can also sed that term.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806098
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
"Using ref is advised over standard reStructuredText links to sections (like `Section title`_) because it works across files, when section headings are changed, and for all builders that support cross-references."
https://www.sphinx-doc.org/en/1.7/markup/inline.html#role-ref
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806614
##########
File path: boards/arm/cxd56xx/spresense/configs/rndis/defconfig
##########
@@ -100,7 +100,6 @@ CONFIG_NSH_DISABLE_TELNETD=y
CONFIG_NSH_FILE_APPS=y
CONFIG_NSH_READLINE=y
CONFIG_NSH_TELNETD_CLIENTSTACKSIZE=3072
-CONFIG_NSH_WGET_USERAGENT="NuttX/7.2x.x (; http://www.nuttx.org/)"
Review comment:
See my comment in the PR. The default is `NuttX/6.x.x (; http://www.nuttx.org/)` which is equally wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479805966
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
But labels are the preferred way otherwise when things move everything has be to updated. I was actually about to make a comment about how this should be updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479805491
##########
File path: Documentation/components/nxwidgets.rst
##########
@@ -43,17 +43,11 @@ Note: Many of the fundamental classed in NxWidgets derive from the
Antony Dzeryn's "Woopsi" project: http://woopsi.org/ which also has a
BSD style license. See the COPYING file for details.
-NXWidgets DOxygen Documentation
+NXWidgets Doxygen Documentation
===============================
-Release notes, DOxygen documentation, as well as downloads for the
-latest NxWidgets releases are available online:
-
-**NxWidgets-1.19**:
-`Documentation <http://nuttx.org/nxwidgets_v1_19/html/index.html>`__,
-`Release
-notes <http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.19/>`__,
-and
-`Downloads <http://sourceforge.net/projects/nuttx/files/NxWidgets/NxWidgets-1.19/>`__
+.. note::
Review comment:
Please use "todo" admonition for notes intended to NuttX maintainers. The rest of admonitions are to address readers of the documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806373
##########
File path: ReleaseNotes
##########
@@ -10975,7 +10977,7 @@ detailed bugfix information):
- SAMV7 Tickless Mode: This is a fix to a problem in the handling of
the oneshot timer. Due to a wrong assumption concerning the behavior
directly after the start of the timer/counter the function
- sam_oneshot_cancel(�) calculates the wrong remaining time. The code
+ sam_oneshot_cancel(�) calculates the wrong remaining time. The code
Review comment:
not sure why this appears
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806426
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
These are in the original file they are unicode characters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479807056
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
By the way, look at this link: https://github.com/apache/incubator-nuttx/pull/1673/files#diff-20a19028a4ef22777368520a40d0cfdbL2908
The diff is displayed differently (the previous works looks OK) but it does not in this per-line comment.
I think you just found a bug in GitHub :laughing:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806541
##########
File path: boards/arm/cxd56xx/spresense/configs/rndis/defconfig
##########
@@ -100,7 +100,6 @@ CONFIG_NSH_DISABLE_TELNETD=y
CONFIG_NSH_FILE_APPS=y
CONFIG_NSH_READLINE=y
CONFIG_NSH_TELNETD_CLIENTSTACKSIZE=3072
-CONFIG_NSH_WGET_USERAGENT="NuttX/7.2x.x (; http://www.nuttx.org/)"
Review comment:
Is it OK to just remove this? Is there a sane default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#issuecomment-683469693
Yeah, but I think commiters have signed up to do the extra to keep the code base clean and this is part of it. I would not expect it from someone outside the project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806837
##########
File path: Documentation/introduction/detailed_support.rst
##########
@@ -110,7 +110,7 @@ Moxa NP51x0
A port to the Moxa NP51x0 series of 2-port advanced
RS-232/422/485 serial device servers was contributed by Anton D.
-Kachalov in NuttX-7.11. This port includes a NuttShell (NSH)
+Kachalov in NuttX-7.11. This port includes :ref:`NSH <nsh>`
Review comment:
Ok, I kind of liked the auto label but I agree it requires more vigilance over not changing section names.
We should then disable the autosectionlabel extension, update the contributing section as you suggest and convert existing uses of section names as labels. This could be done in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#issuecomment-683468548
Ooof. This is one of those fixes where you try to do a little thing and it ends up in a bit of a rabbit hole.
I made the style fixes to `kinetis_lowput.c` but it looks like the registers were never defined in the header only the offsets so there is a lot of uart_base+<offset> going on in that C file unfortunately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479806547
##########
File path: ReleaseNotes
##########
@@ -2905,7 +2907,7 @@ That command will mount the remote NFS server directory <remote-path> at
the remote server.
The NFS development was the graduation project of Jose Pablo Rojas V. who
-is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
+is a student at the Instituto Tecnol�gico de Costa Rica (ITCR, or TEC).
Review comment:
ah I see my editor broke them further... Ugh, I'll see what I can do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479811644
##########
File path: boards/arm/lpc17xx_40xx/olimex-lpc1766stk/README.txt
##########
@@ -135,11 +135,11 @@ Olimex LPC1766-STK development board
LDS176 controller but it is 100% compatible with the Philips PCF8833).
So how do you tell which controller you have? Some message boards have
suggested that the LCD display be disassembled and the controller chip
- measured with a digital caliper � well that�s getting a bit extreme.
+ measured with a digital caliper � well that�s getting a bit extreme.
- "Here�s what I know. The Olimex boards have both display controllers
- possible; if the LCD has a GE-12 sticker on it, it�s a Philips PCF8833.
- If it has a GE-8 sticker, it�s an Epson controller. The older Sparkfun
+ "Here�s what I know. The Olimex boards have both display controllers
Review comment:
Yep you are right, I have a list, updating them now as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#discussion_r479807136
##########
File path: boards/arm/cxd56xx/spresense/configs/rndis/defconfig
##########
@@ -100,7 +100,6 @@ CONFIG_NSH_DISABLE_TELNETD=y
CONFIG_NSH_FILE_APPS=y
CONFIG_NSH_READLINE=y
CONFIG_NSH_TELNETD_CLIENTSTACKSIZE=3072
-CONFIG_NSH_WGET_USERAGENT="NuttX/7.2x.x (; http://www.nuttx.org/)"
Review comment:
Oh ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on pull request #1673: Docs: Update links to old website and wiki
Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #1673:
URL: https://github.com/apache/incubator-nuttx/pull/1673#issuecomment-683469937
> Yeah, but I think commiters have signed up to do the extra to keep the code base clean and this is part of it. I would not expect it from someone outside the project.
Agreed. Would be cool to see a little progress bar of coding style compliance for whole project as an incentive =)
Anyway, LGTM. Will do when CI test pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org