You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/30 01:48:46 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25414: Simplify dataset api tests

uranusjr commented on code in PR #25414:
URL: https://github.com/apache/airflow/pull/25414#discussion_r933705960


##########
tests/api_connexion/endpoints/test_dataset_endpoint.py:
##########
@@ -53,21 +53,23 @@ class TestDatasetEndpoint:
     default_time = "2020-06-11T18:00:00+00:00"
 
     @pytest.fixture(autouse=True)
-    def setup_attrs(self, configured_app) -> None:
+    def setup(self, configured_app):

Review Comment:
   Don’t call this `setup`, the function name has special meaning to Pytest (it would not pick up that special meaning here due to the fixture decorator, but it’s better to not confuse things)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org