You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/01 02:58:44 UTC

[GitHub] [calcite] chunweilei commented on a change in pull request #2030: [CALCITE-4098] Remove redundant code in "RelJson.toJson(RelDistribution)".

chunweilei commented on a change in pull request #2030:
URL: https://github.com/apache/calcite/pull/2030#discussion_r448088033



##########
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##########
@@ -385,6 +385,34 @@
       + "  ]\n"
       + "}";
 
+  public static final String XX4 = "{\n"
+      + "  \"rels\": [\n"
+      + "    {\n"
+      + "      \"id\": \"0\",\n"

Review comment:
       Please use a more readable name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org