You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/03 08:00:24 UTC

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

piotr-szuberski commented on a change in pull request #12758:
URL: https://github.com/apache/beam/pull/12758#discussion_r482784051



##########
File path: CHANGES.md
##########
@@ -100,6 +100,8 @@
 * Support for X source added (Java/Python) ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)).
 * Add streaming support to SnowflakeIO in Java SDK ([BEAM-9896](https://issues.apache.org/jira/browse/BEAM-9896  ))
 * Support reading and writing to Google Healthcare DICOM APIs in Python SDK ([BEAM-10601](https://issues.apache.org/jira/browse/BEAM-10601))
+* Add dispositions for SnowflakeIO.write ([BEAM-10343](https://issues.apache.org/jira/browse/BEAM-10343))

Review comment:
       @youngoli Could I also ask you to change these lines (103, 104, 140, 141 as well? I've noticed that snowflake dispositions and cross-language read was added in 2.24, not 2.23 (it was pushed at 2.23 but was merged after the 2.23 release)
   It would also be great to move snowflake.py from apache_beam.io.external to apache_beam.io but I don't know how much changes would you like to do. But we would avoid backward compatibility issues with this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org