[jira] [Commented] (SLING-9968) ObjectModel.toString() should support more classes

["Radu Cotescu (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-9968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388532#comment-17388532 ] 

Radu Cotescu commented on SLING-9968:
-------------------------------------

I've used {{java.lang.Enum#name}} because somebody might use an enum constant in a test expression and you want the test condition to be stable, since {{#toString}} can be changed at any point in time without affecting the binary compatibility. See this extract from {{java.lang.Enum#name}}'s JavaDoc:

{quote}
This method is designed primarily for use in specialized situations where correctness depends on getting the exact name, which will not vary from release to release.
{quote}

> ObjectModel.toString() should support more classes
> --------------------------------------------------
>
>                 Key: SLING-9968
>                 URL: https://issues.apache.org/jira/browse/SLING-9968
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting HTL Engine 1.4.6-1.4.0
>            Reporter: Konrad Windszus
>            Priority: Major
>
> For getter methods returning e.g. a {{java.net.URI}} there is no implicit {{toString()}} being applied. When looking at the HTL specs it seems not defined how to deal with complex objects (https://github.com/adobe/htl-spec/blob/master/SPECIFICATION.md#1152-string), but given that enums and primitives are automatically converted (https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/blob/6cbd676a8875af756e6e43b38c39ba9e4784dc4e/src/main/java/org/apache/sling/scripting/sightly/render/ObjectModel.java#L238) already, I am wondering why other types like {{URI}} or {{URL}} are not supported.
> Is there any harm when doing object.toString() as fallback?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)