You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by be...@apache.org on 2010/01/18 22:32:21 UTC
svn commit: r900569 - in /maven/maven-3/trunk/maven-core/src: main/java/org/apache/maven/execution/ test/java/org/apache/maven/execution/

Author: bentmann
Date: Mon Jan 18 21:32:21 2010
New Revision: 900569

URL: http://svn.apache.org/viewvc?rev=900569&view=rev
Log:
o Fixed request copying to actually return copy

Added:
    maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTest.java
      - copied, changed from r900540, maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTestCase.java
Removed:
    maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTestCase.java
Modified:
    maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java

Modified: maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java?rev=900569&r1=900568&r2=900569&view=diff
==============================================================================
--- maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java (original)
+++ maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java Mon Jan 18 21:32:21 2010
@@ -172,7 +172,7 @@
         copy.setRepositoryCache( original.getRepositoryCache() );
         copy.setNoSnapshotUpdates( original.isNoSnapshotUpdates() );
         copy.setExecutionListener( original.getExecutionListener() );
-        return original;
+        return copy;
     }
 
     public String getBaseDirectory()

Copied: maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTest.java (from r900540, maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTestCase.java)
URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTest.java?p2=maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTest.java&p1=maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTestCase.java&r1=900540&r2=900569&rev=900569&view=diff
==============================================================================
--- maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTestCase.java (original)
+++ maven/maven-3/trunk/maven-core/src/test/java/org/apache/maven/execution/DefaultMavenExecutionTest.java Mon Jan 18 21:32:21 2010
@@ -24,13 +24,16 @@
 /**
  * @author Benjamin Bentmann
  */
-public class DefaultMavenExecutionTestCase
+public class DefaultMavenExecutionTest
     extends TestCase
 {
 
     public void testCopyDefault()
     {
-        assertNotNull( DefaultMavenExecutionRequest.copy( new DefaultMavenExecutionRequest() ) );
+        MavenExecutionRequest original = new DefaultMavenExecutionRequest();
+        MavenExecutionRequest copy = DefaultMavenExecutionRequest.copy( original );
+        assertNotNull( copy );
+        assertNotSame( copy, original );
     }
 
 }