You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2016/03/24 23:28:19 UTC
Re: Review Request 45321: Ambari calculates stack downgrade as
ABORTED under
incorrect conditions. UI shows 'Downgrade paused' and button to resume
downgrade even when progress is happening
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45321/
-----------------------------------------------------------
(Updated March 24, 2016, 10:28 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Summary (updated)
-----------------
Ambari calculates stack downgrade as ABORTED under incorrect conditions. UI shows 'Downgrade paused' and button to resume downgrade even when progress is happening
Bugs: AMBARI-15569
https://issues.apache.org/jira/browse/AMBARI-15569
Repository: ambari
Description
-------
*STR:*
1. Install Ambari 2.2.0
2. Upgrade stack from HDP-2.2.4 to HDP-2.3.2
3. At finalize step, choose downgrade option
4. Introduce failures in some clients such as Zookeeper and Yarn.
In this case, the status of some tasks are marked as ABORTED.
This causes the overall status of the Downgrade to be ABORTED, and hence the UI shows an incorrect message and button.
Technically, the Downgrade is still progressing, yet the UI shows "Downgrade paused" and a button to "Resume Downgrade"
This means that the calculations of the stages is incorrect.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 1d8df9b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d43daca
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java fd866a1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 8d80fa6
Diff: https://reviews.apache.org/r/45321/diff/
Testing
-------
Verified on live cluster and ran unit tests in CalculateStatusTest.java
Thanks,
Alejandro Fernandez
Re: Review Request 45321: Ambari calculates stack downgrade as
ABORTED under
incorrect conditions. UI shows 'Downgrade paused' and button to resume
downgrade even when progress is happening
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45321/
-----------------------------------------------------------
(Updated March 28, 2016, 11:14 p.m.)
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
Changes
-------
Fixed unit tests and removed getSuspended() method since isSuspended() already exists.
Bugs: AMBARI-15569
https://issues.apache.org/jira/browse/AMBARI-15569
Repository: ambari
Description
-------
*STR:*
1. Install Ambari 2.2.0
2. Upgrade stack from HDP-2.2.4 to HDP-2.3.2
3. At finalize step, choose downgrade option
4. Introduce failures in some clients such as Zookeeper and Yarn.
In this case, the status of some tasks are marked as ABORTED.
This causes the overall status of the Downgrade to be ABORTED, and hence the UI shows an incorrect message and button.
Technically, the Downgrade is still progressing, yet the UI shows "Downgrade paused" and a button to "Resume Downgrade"
This means that the calculations of the stages is incorrect.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 1d8df9b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d43daca
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java fd866a1
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 8d80fa6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java c18a8b6
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java d37f3ba
Diff: https://reviews.apache.org/r/45321/diff/
Testing
-------
Verified on live cluster and ran unit tests in CalculateStatusTest.java
Thanks,
Alejandro Fernandez
Re: Review Request 45321: Ambari calculates stack downgrade as
ABORTED under
incorrect conditions. UI shows 'Downgrade paused' and button to resume
downgrade even when progress is happening
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45321/#review125740
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java (lines 203 - 205)
<https://reviews.apache.org/r/45321/#comment188591>
I see this in trunk already as isSuspended() ?
- Nate Cole
On March 24, 2016, 6:28 p.m., Alejandro Fernandez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45321/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 6:28 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-15569
> https://issues.apache.org/jira/browse/AMBARI-15569
>
>
> Repository: ambari
>
>
> Description
> -------
>
> *STR:*
> 1. Install Ambari 2.2.0
> 2. Upgrade stack from HDP-2.2.4 to HDP-2.3.2
> 3. At finalize step, choose downgrade option
> 4. Introduce failures in some clients such as Zookeeper and Yarn.
>
> In this case, the status of some tasks are marked as ABORTED.
> This causes the overall status of the Downgrade to be ABORTED, and hence the UI shows an incorrect message and button.
> Technically, the Downgrade is still progressing, yet the UI shows "Downgrade paused" and a button to "Resume Downgrade"
>
> This means that the calculations of the stages is incorrect.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java 1d8df9b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java d43daca
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java fd866a1
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CalculatedStatusTest.java 8d80fa6
>
> Diff: https://reviews.apache.org/r/45321/diff/
>
>
> Testing
> -------
>
> Verified on live cluster and ran unit tests in CalculateStatusTest.java
>
>
> Thanks,
>
> Alejandro Fernandez
>
>