[GitHub] [airflow] Udbv opened a new issue #20999: ArgoCD deployment: build in redis is not restarted on password change

[GitBox <gi...@apache.org>]

Udbv opened a new issue #20999:
URL: https://github.com/apache/airflow/issues/20999


   ### Official Helm Chart version
   
   1.4.0 (latest released)
   
   ### Apache Airflow version
   
   2.2.3 (latest released)
   
   ### Kubernetes Version
   
   1.21.x,1.18.x
   
   ### Helm Chart configuration
   
   KubernetesCeleryExecutor used
   
   ### Docker Image customisations
   
   _No response_
   
   ### What happened
   
   On each argocd airflow app update ```{{ .Release.Name }}-redis-password``` and ```{{ .Release.Name }}-broker-url``` is regenerated(since argocd do not honor ```"helm.sh/hook": "pre-install"```). airflow pods restarted(as expected),get new redis connection and connection start failing with WRONG_PASSWORD, since redis is not restarted(old password used). Redis in chart 1.4 have no health checks.
   
   ### What you expected to happen
   
   Generally, I have two options:
   
   1. (Prefered) Add health check to Redis with login sequence. The password should be updated "on the fly"(read from the mounted secret and try to connect)
   2. (Workeraund) I implemented a workaround with the parent chart. ```{{ .Release.Name }}-Redis-password``` and ```{{ .Release.Name }}-broker-url``` secrets generated from template where ```immutable: true``` added to the secret definition.
   
   ### How to reproduce
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #20999: ArgoCD deployment: build in redis is not restarted on password change

[GitBox <gi...@apache.org>]

boring-cyborg[bot] commented on issue #20999:
URL: https://github.com/apache/airflow/issues/20999#issuecomment-1017921324


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org