You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/06/06 20:20:30 UTC
Review Request 59855: Set the fetcher cache size at construction time.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59855/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-7524
https://issues.apache.org/jira/browse/MESOS-7524
Repository: mesos
Description
-------
Fixing the TODO, set the FetcherProcess::Cache size at construction time
rather than updating it in a separate setter function.
Diffs
-----
src/slave/containerizer/fetcher.hpp efeadbf4b7804ea4c1e443d1e5212e303796ace4
src/slave/containerizer/fetcher.cpp 770cad3e046e8a6d58b6bc9176eb7ecdbd340db4
Diff: https://reviews.apache.org/r/59855/diff/1/
Testing
-------
make check (Fedora 25)
Thanks,
James Peach
Re: Review Request 59855: Set the fetcher cache size at construction
time.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59855/#review178528
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On June 6, 2017, 1:20 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59855/
> -----------------------------------------------------------
>
> (Updated June 6, 2017, 1:20 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7524
> https://issues.apache.org/jira/browse/MESOS-7524
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixing the TODO, set the FetcherProcess::Cache size at construction time
> rather than updating it in a separate setter function.
>
>
> Diffs
> -----
>
> src/slave/containerizer/fetcher.hpp efeadbf4b7804ea4c1e443d1e5212e303796ace4
> src/slave/containerizer/fetcher.cpp 770cad3e046e8a6d58b6bc9176eb7ecdbd340db4
>
>
> Diff: https://reviews.apache.org/r/59855/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 25)
>
>
> Thanks,
>
> James Peach
>
>