[GitHub] [druid] gianm commented on a diff in pull request #12657: Fix flaky KafkaIndexTaskTest.

[GitBox <gi...@apache.org>]

gianm commented on code in PR #12657:
URL: https://github.com/apache/druid/pull/12657#discussion_r906209636


##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/KafkaIndexTaskTest.java:
##########
@@ -2572,7 +2566,9 @@ public void testRunTransactionModeRollback() throws Exception
             0,
             "sequence0",
             new SeekableStreamStartSequenceNumbers<>(topic, ImmutableMap.of(0, 0L), ImmutableSet.of()),
-            new SeekableStreamEndSequenceNumbers<>(topic, ImmutableMap.of(0, 13L)),
+
+            // End offset 13 is one after 12 real messages + 2 txn control messages (last seen message: offset 13).
+            new SeekableStreamEndSequenceNumbers<>(topic, ImmutableMap.of(0, 14L)),

Review Comment:
   The flow is slightly different: I added one additional transaction to the test. So there's one more control message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org