[GitHub] [airflow] potiuk commented on a change in pull request #11157: New Breeze command start-airflow, it replaces the previous flag

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #11157:
URL: https://github.com/apache/airflow/pull/11157#discussion_r495489215



##########
File path: breeze
##########
@@ -1663,6 +1682,23 @@ ${CMDNAME} setup-autocomplete
       parameters and values.
 "
     readonly DETAILED_USAGE_SETUP_AUTOCOMPLETE
+    export DETAILED_USAGE_START_AIRFLOW="
+${CMDNAME} start-airflow
+
+      Like the Shell command this will enter the interactive shell, but it will also start
+      automatically the Scheduler and the Webserver. It will leave you in a tmux session where you
+      can also observe what is happening in your Airflow.
+
+      This is a convenient way to setup a development environment. Your dags will be loaded from the
+      folder 'files/dags' on your host machine (it could take some times).
+
+      If you don't want to load default connections and example dags add the flag
+      --skip-tutorial objects.

Review comment:
       The description still refers to the --skip-tutorial-objects flag :).

##########
File path: scripts/in_container/run_tmux.sh
##########
@@ -0,0 +1,53 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+if [[ ${START_AIRFLOW:="false"} == "true" ]]; then
+
+    ln -s "${IN_CONTAINER_DIR}/stop_tmux_airflow.sh" stop_airflow.sh

Review comment:
       It would be great to print information about the stop_airlfow.sh command. I find it super useful but it's hard to discover. I think the best way is to print it in the terminal that you are dropped at :) 
   
   "You can use 'stop_tmux_airflow.sh' to kill the whole session"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org