You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GuoLei Yi <yi...@gmail.com> on 2022/04/25 08:13:20 UTC
[DISCUSS] Add requested CI check for Pull Requests
Hello everyone, with the increasing number of pull requests, we need to
strictly control the code merge process. I plan to turn on "requested" CI
checks, that is, when all "requested" CI checks of a PR pass, the code can
be merged. The following admissions will be forced on: 1. BE Code Formatter
/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
License Check / License Check (pull_request): License Header check. 4. BE
UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
regression test. PPMC members are obliged to manage the above CI
checks. Welcome
to discuss this, after unanimous agreement, I will apply to ASF Infra to
open requested CI.
--
祝您心情愉快
衣国垒
Tsing Hua University
Tel:134-3991-0228
Email:yiguolei@gmail.com
Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by Lijia Liu <li...@gmail.com>.
+1<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<br/><br/><br/><html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<div>
<div class="ntes-mailmaster-quote" style="padding-top: 1px; padding-bottom: 1px" >
<div style=" margin-top: 2em; margin-bottom: 1em; font-size: 14px; line-height: 1.25; color: #78787a; " >---- 回复的原邮件 ----</div>
<div style=" margin-bottom: 1em; font-size: 12px; line-height: 1.25; color: #232324; padding: 0.5em 0.25em; border-radius: 0.67em; background-color: #f0f0f0; " >
<table width="100%" cellpadding="0" cellspacing="9" border="0">
<tr>
<td valign="top" style=" width: 4.25em; font-size: 12px; line-height: 1.25; color: #78787a; " >
发件人
</td>
<td valign="top" style=" font-size: 12px; line-height: 1.25; color: #232324; word-break: break-all; " >
<a class="mail-from" style="text-decoration:none;color:#0886e8;" href="mailto:yiguolei@gmail.com">GuoLei Yi<yiguolei@gmail.com></a>
</td>
</tr>
<tr>
<td valign="top" style=" width: 4.25em; font-size: 12px; line-height: 1.25; color: #78787a; " >
日期
</td>
<td class="mail-date" valign="top" style=" font-size: 12px; line-height: 1.25; color: #232324; word-break: break-all; " >
2022年04月25日 16:13
</td>
</tr>
<tr style="">
<td valign="top" style=" width: 4.25em; font-size: 12px; line-height: 1.25; color: #78787a; " >
收件人
</td>
<td valign="top" style=" font-size: 12px; line-height: 1.25; color: #232324; word-break: break-all; " >
<a class="mail-to" style="text-decoration:none;color:#0886e8;" href="mailto:dev@doris.apache.org">dev@doris.apache.org<dev@doris.apache.org></a>
</td>
</tr>
<tr style="display:none;">
<td valign="top" style=" width: 4.25em; font-size: 12px; line-height: 1.25; color: #78787a; " >
抄送至
</td>
<td valign="top" style=" font-size: 12px; line-height: 1.25; color: #232324; word-break: break-all; " >
</td>
</tr>
<tr>
<td valign="top" style=" width: 4.25em; font-size: 12px; line-height: 1.25; color: #78787a; " >
主题
</td>
<td class="mail-subject" valign="top" style=" font-size: 12px; line-height: 1.25; color: #232324; word-break: break-all; " >
[DISCUSS] Add requested CI check for Pull Requests
</td>
</tr>
</table>
</div>
<div>Hello everyone, with the increasing number of pull requests, we need to
<br/>strictly control the code merge process. I plan to turn on "requested" CI
<br/>checks, that is, when all "requested" CI checks of a PR pass, the code can
<br/>be merged. The following admissions will be forced on: 1. BE Code Formatter
<br/>/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
<br/>Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
<br/>License Check / License Check (pull_request): License Header check. 4. BE
<br/>UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
<br/>test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
<br/>regression test. PPMC members are obliged to manage the above CI
<br/>checks. Welcome
<br/>to discuss this, after unanimous agreement, I will apply to ASF Infra to
<br/>open requested CI.
<br/>--
<br/>祝您心情愉快
<br/>
<br/>衣国垒
<br/>Tsing Hua University
<br/>Tel:134-3991-0228
<br/>Email:yiguolei@gmail.com
<br/></div>
</div>
</div>
</html>
</body>
</html>
Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by De Li <li...@apache.org>.
+1
李德
lide@apache.org
On 2022/04/25 08:13:20 GuoLei Yi wrote:
> Hello everyone, with the increasing number of pull requests, we need to
> strictly control the code merge process. I plan to turn on "requested" CI
> checks, that is, when all "requested" CI checks of a PR pass, the code can
> be merged. The following admissions will be forced on: 1. BE Code Formatter
> / Clang Formatter (pull_request): Code formatter for BE. 2. Build
> Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
> License Check / License Check (pull_request): License Header check. 4. BE
> UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
> test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
> regression test. PPMC members are obliged to manage the above CI
> checks. Welcome
> to discuss this, after unanimous agreement, I will apply to ASF Infra to
> open requested CI.
> --
> 祝您心情愉快
>
> 衣国垒
> Tsing Hua University
> Tel:134-3991-0228
> Email:yiguolei@gmail.com
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org
回复：[DISCUSS] Add requested CI check for Pull Requests
Posted by stephen <he...@qq.com.INVALID>.
+1
------------------ 原始邮件 ------------------
发件人: "dev" <morningman@163.com>;
发送时间: 2022年4月25日(星期一) 下午4:17
收件人: "dev"<dev@doris.apache.org>;
主题: Re:[DISCUSS] Add requested CI check for Pull Requests
+1
--
此致！Best Regards
陈明雨 Mingyu Chen
Email:
chenmingyu@apache.org
At 2022-04-25 16:13:20, "GuoLei Yi" <yiguolei@gmail.com> wrote:
>Hello everyone, with the increasing number of pull requests, we need to
>strictly control the code merge process. I plan to turn on "requested" CI
>checks, that is, when all "requested" CI checks of a PR pass, the code can
>be merged. The following admissions will be forced on: 1. BE Code Formatter
>/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
>Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
>License Check / License Check (pull_request): License Header check. 4. BE
>UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
>test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
>regression test. PPMC members are obliged to manage the above CI
>checks. Welcome
>to discuss this, after unanimous agreement, I will apply to ASF Infra to
>open requested CI.
>--
>祝您心情愉快
>
>衣国垒
>Tsing Hua University
>Tel:134-3991-0228
>Email:yiguolei@gmail.com
Re:Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by 陈明雨 <mo...@163.com>.
> 4. I can not login to the new TeamCity. The CI tools should easily
accessible to all contributors.
You can click "login as guest"
And later I think the PPMC member should have admin privilege.
--
此致！Best Regards
陈明雨 Mingyu Chen
Email:
chenmingyu@apache.org
在 2022-04-25 16:30:31，"ling miao" <li...@apache.org> 写道：
>1. FE code format should be "requested" in the future.
>
>2. There are some duplicate checks should be removed such as: Incubator
>Doris UT.
>
>3. I recommend keeping the original P0 check until the P0 case is migrated.
>
>4. I can not login to the new TeamCity. The CI tools should easily
>accessible to all contributors.
>
>Ling Miao
>
>陈明雨 <mo...@163.com> 于2022年4月25日周一 16:17写道：
>
>> +1
>>
>>
>>
>> --
>>
>> 此致！Best Regards
>> 陈明雨 Mingyu Chen
>>
>> Email:
>> chenmingyu@apache.org
>>
>>
>>
>>
>>
>> At 2022-04-25 16:13:20, "GuoLei Yi" <yi...@gmail.com> wrote:
>> >Hello everyone, with the increasing number of pull requests, we need to
>> >strictly control the code merge process. I plan to turn on "requested" CI
>> >checks, that is, when all "requested" CI checks of a PR pass, the code can
>> >be merged. The following admissions will be forced on: 1. BE Code
>> Formatter
>> >/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
>> >Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/.
>> 3.
>> >License Check / License Check (pull_request): License Header check. 4. BE
>> >UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
>> >test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
>> >regression test. PPMC members are obliged to manage the above CI
>> >checks. Welcome
>> >to discuss this, after unanimous agreement, I will apply to ASF Infra to
>> >open requested CI.
>> >--
>> >祝您心情愉快
>> >
>> >衣国垒
>> >Tsing Hua University
>> >Tel:134-3991-0228
>> >Email:yiguolei@gmail.com
>>
>
>
>--
>Ling Miao | Apache Doris
Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by ling miao <li...@apache.org>.
1. FE code format should be "requested" in the future.
2. There are some duplicate checks should be removed such as: Incubator
Doris UT.
3. I recommend keeping the original P0 check until the P0 case is migrated.
4. I can not login to the new TeamCity. The CI tools should easily
accessible to all contributors.
Ling Miao
陈明雨 <mo...@163.com> 于2022年4月25日周一 16:17写道：
> +1
>
>
>
> --
>
> 此致！Best Regards
> 陈明雨 Mingyu Chen
>
> Email:
> chenmingyu@apache.org
>
>
>
>
>
> At 2022-04-25 16:13:20, "GuoLei Yi" <yi...@gmail.com> wrote:
> >Hello everyone, with the increasing number of pull requests, we need to
> >strictly control the code merge process. I plan to turn on "requested" CI
> >checks, that is, when all "requested" CI checks of a PR pass, the code can
> >be merged. The following admissions will be forced on: 1. BE Code
> Formatter
> >/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
> >Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/.
> 3.
> >License Check / License Check (pull_request): License Header check. 4. BE
> >UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
> >test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
> >regression test. PPMC members are obliged to manage the above CI
> >checks. Welcome
> >to discuss this, after unanimous agreement, I will apply to ASF Infra to
> >open requested CI.
> >--
> >祝您心情愉快
> >
> >衣国垒
> >Tsing Hua University
> >Tel:134-3991-0228
> >Email:yiguolei@gmail.com
>
--
Ling Miao | Apache Doris
Re:[DISCUSS] Add requested CI check for Pull Requests
Posted by 陈明雨 <mo...@163.com>.
+1
--
此致！Best Regards
陈明雨 Mingyu Chen
Email:
chenmingyu@apache.org
At 2022-04-25 16:13:20, "GuoLei Yi" <yi...@gmail.com> wrote:
>Hello everyone, with the increasing number of pull requests, we need to
>strictly control the code merge process. I plan to turn on "requested" CI
>checks, that is, when all "requested" CI checks of a PR pass, the code can
>be merged. The following admissions will be forced on: 1. BE Code Formatter
>/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
>Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
>License Check / License Check (pull_request): License Header check. 4. BE
>UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
>test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
>regression test. PPMC members are obliged to manage the above CI
>checks. Welcome
>to discuss this, after unanimous agreement, I will apply to ASF Infra to
>open requested CI.
>--
>祝您心情愉快
>
>衣国垒
>Tsing Hua University
>Tel:134-3991-0228
>Email:yiguolei@gmail.com
Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by ling miao <li...@apache.org>.
> BTW, I have a small problem, currently BE UT, BE UT, P0 regression,
Incubator Doris UT are all running with personal accounts, the risk of
whether they can continue to run, and also need the account password to
view the failure information, so it is not very convenient, can you migrate
to the official github service
Same problem
zhg yang <ya...@gmail.com> 于2022年4月25日周一 16:41写道：
> +1
>
> BTW, I have a small problem, currently BE UT, BE UT, P0 regression,
> Incubator Doris UT are all running with personal accounts, the risk of
> whether they can continue to run, and also need the account password to
> view the failure information, so it is not very convenient, can you migrate
> to the official github service
>
>
>
> 在 2022/4/25 16:13，“GuoLei Yi”<yi...@gmail.com> 写入:
>
> Hello everyone, with the increasing number of pull requests, we need to
> strictly control the code merge process. I plan to turn on "requested"
> CI
> checks, that is, when all "requested" CI checks of a PR pass, the code
> can
> be merged. The following admissions will be forced on: 1. BE Code
> Formatter
> / Clang Formatter (pull_request): Code formatter for BE. 2. Build
> Extensions / Build Extensions (pull_request): Compile for
> fs_broker/doc/. 3.
> License Check / License Check (pull_request): License Header check. 4.
> BE
> UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
> test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
> regression test. PPMC members are obliged to manage the above CI
> checks. Welcome
> to discuss this, after unanimous agreement, I will apply to ASF Infra
> to
> open requested CI.
> --
> 祝您心情愉快
>
> 衣国垒
> Tsing Hua University
> Tel:134-3991-0228
> Email:yiguolei@gmail.com
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
> For additional commands, e-mail: dev-help@doris.apache.org
>
>
--
Ling Miao | Apache Doris
Re:Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by 陈明雨 <mo...@163.com>.
> BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can ? > continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to the official github service1. The github action is not very easy to use. The default VM github provide is only 2C4G, so that it can not meet the requirement of build BE.
There is a "self-hosted runner" option for github action, But ASF Infra is not recommended to do in that way because there are some safety issue.
2. You don't need password to view the build log, you can just click "login as user" to view the log.
--
此致！Best Regards
陈明雨 Mingyu Chen
Email:
chenmingyu@apache.org
在 2022-04-25 16:41:00，"zhg yang" <ya...@gmail.com> 写道：
>+1
>
>BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to the official github service
>
>
>
>在 2022/4/25 16:13，“GuoLei Yi”<yi...@gmail.com> 写入:
>
> Hello everyone, with the increasing number of pull requests, we need to
> strictly control the code merge process. I plan to turn on "requested" CI
> checks, that is, when all "requested" CI checks of a PR pass, the code can
> be merged. The following admissions will be forced on: 1. BE Code Formatter
> / Clang Formatter (pull_request): Code formatter for BE. 2. Build
> Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
> License Check / License Check (pull_request): License Header check. 4. BE
> UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
> test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
> regression test. PPMC members are obliged to manage the above CI
> checks. Welcome
> to discuss this, after unanimous agreement, I will apply to ASF Infra to
> open requested CI.
> --
> 祝您心情愉快
>
> 衣国垒
> Tsing Hua University
> Tel:134-3991-0228
> Email:yiguolei@gmail.com
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
>For additional commands, e-mail: dev-help@doris.apache.org
Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by zhg yang <ya...@gmail.com>.
+1
BTW, I have a small problem, currently BE UT, BE UT, P0 regression, Incubator Doris UT are all running with personal accounts, the risk of whether they can continue to run, and also need the account password to view the failure information, so it is not very convenient, can you migrate to the official github service
在 2022/4/25 16:13，“GuoLei Yi”<yi...@gmail.com> 写入:
Hello everyone, with the increasing number of pull requests, we need to
strictly control the code merge process. I plan to turn on "requested" CI
checks, that is, when all "requested" CI checks of a PR pass, the code can
be merged. The following admissions will be forced on: 1. BE Code Formatter
/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
License Check / License Check (pull_request): License Header check. 4. BE
UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
regression test. PPMC members are obliged to manage the above CI
checks. Welcome
to discuss this, after unanimous agreement, I will apply to ASF Infra to
open requested CI.
--
祝您心情愉快
衣国垒
Tsing Hua University
Tel:134-3991-0228
Email:yiguolei@gmail.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org
Re: [DISCUSS] Add requested CI check for Pull Requests
Posted by 41108453 <41...@qq.com.INVALID>.
+1
------------------ Original ------------------
From: GuoLei Yi <yiguolei@gmail.com>
Date: Mon,Apr 25,2022 4:13 PM
To: dev <dev@doris.apache.org>
Subject: Re: [DISCUSS] Add requested CI check for Pull Requests
Hello everyone, with the increasing number of pull requests, we need to
strictly control the code merge process. I plan to turn on "requested" CI
checks, that is, when all "requested" CI checks of a PR pass, the code can
be merged. The following admissions will be forced on: 1. BE Code Formatter
/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
License Check / License Check (pull_request): License Header check. 4. BE
UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
regression test. PPMC members are obliged to manage the above CI
checks. Welcome
to discuss this, after unanimous agreement, I will apply to ASF Infra to
open requested CI.
--
祝您心情愉快
衣国垒
Tsing Hua University
Tel:134-3991-0228
Email:yiguolei@gmail.com
Re:[DISCUSS] Add requested CI check for Pull Requests
Posted by stalary <st...@163.com>.
+1
| |
stalary
|
|
stalary@163.com
|
签名由网易邮箱大师定制
On 04/25/2022 16:13，GuoLei Yi<yi...@gmail.com> wrote：
Hello everyone, with the increasing number of pull requests, we need to
strictly control the code merge process. I plan to turn on "requested" CI
checks, that is, when all "requested" CI checks of a PR pass, the code can
be merged. The following admissions will be forced on: 1. BE Code Formatter
/ Clang Formatter (pull_request): Code formatter for BE. 2. Build
Extensions / Build Extensions (pull_request): Compile for fs_broker/doc/. 3.
License Check / License Check (pull_request): License Header check. 4. BE
UT (Doris BE UT): Run BE unit test. 5. FE UT (Doris FE UT): Run FE unit
test. 6. P0 regression (Doris P0 regression): Compile FE/BE and run
regression test. PPMC members are obliged to manage the above CI
checks. Welcome
to discuss this, after unanimous agreement, I will apply to ASF Infra to
open requested CI.
--
祝您心情愉快
衣国垒
Tsing Hua University
Tel:134-3991-0228
Email:yiguolei@gmail.com