You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Piotr Nowojski (JIRA)" <ji...@apache.org> on 2019/05/23 11:58:00 UTC

[jira] [Commented] (FLINK-12536) Make BufferOrEventSequence#getNext() non-blocking

    [ https://issues.apache.org/jira/browse/FLINK-12536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846665#comment-16846665 ] 

Piotr Nowojski commented on FLINK-12536:
----------------------------------------

Thanks for showing an interest in this issue [~klion26]. Before implementing this, could you share in this ticket how would you like to implement it?

> Make BufferOrEventSequence#getNext() non-blocking
> -------------------------------------------------
>
>                 Key: FLINK-12536
>                 URL: https://issues.apache.org/jira/browse/FLINK-12536
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Network
>    Affects Versions: 1.9.0
>            Reporter: Piotr Nowojski
>            Assignee: Congxian Qiu(klion26)
>            Priority: Major
>
> Currently it is non-blocking in case of credit-based flow control (default), however for \{{SpilledBufferOrEventSequence}} it is blocking on reading from file. We might want to consider reimplementing it to be non blocking with {{CompletableFuture<?> isAvailable()}} method.
>  
> Otherwise we will block mailbox processing for the duration of reading from file - for example we will block processing time timers and potentially in the future network flushes.
>  
> This is not a high priority change, since it affects non-default configuration option AND at the moment only processing time timers are planned to be moved to the mailbox for 1.9.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)