You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gong (via GitHub)" <gi...@apache.org> on 2023/05/29 09:16:21 UTC

[GitHub] [inlong] gong opened a new pull request, #8117: [INLONG-8116][Sort] Support table api config setting

gong opened a new pull request, #8117:
URL: https://github.com/apache/inlong/pull/8117

   ### Prepare a Pull Request
   
   - [INLONG-8116][Sort] Support table api config setting
   
   - Fixes #8116 
   
   ### Motivation
   
   Support table api config setting
   ref to https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/
   
   ### Modifications
   
   Add two table config setting in sort core
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] EMsnap commented on a diff in pull request #8117: [INLONG-8116][Sort] Support table api config setting

Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #8117:
URL: https://github.com/apache/inlong/pull/8117#discussion_r1209659371


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/configuration/Constants.java:
##########
@@ -97,6 +97,31 @@ public class Constants {
      */
     public static final String PIPELINE_NAME = "pipeline.name";
 
+    /**
+     * https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/
+     * default AUTO
+     */
+    public static final String TABLE_EXEC_SINK_UPSERT_MATERIALIZE = "table.exec.sink.upsert-materialize";
+
+    public static final ConfigOption<String> UPSERT_MATERIALIZE =
+            key("table.exec.sink.upsert-materialize").defaultValue("AUTO").withDescription("Because of the disorder "
+                    + "of ChangeLog data caused by Shuffle in distributed system, the data received by Sink may not "
+                    + "be the order of global upsert. So add upsert materialize operator before upsert sink. It "
+                    + "receives the upstream changelog records and generate an upsert view for the downstream.\n"
+                    + "By default, the materialize operator will be added when a distributed disorder occurs on "
+                    + "unique keys. You can also choose no materialization(NONE) or force materialization(FORCE).");
+
+    public static final String TABLE_EXEC_SINK_NOT_NULL_ENFORCER = "table.exec.sink.not-null-enforcer";
+
+    public static final ConfigOption<String> NOT_NULL_ENFORCER =
+            key("table.exec.sink.not-null-enforcer").defaultValue("ERROR").withDescription("Determines how Flink "
+                    + "enforces NOT NULL column constraints when inserting null values.\n"
+                    + "\n"

Review Comment:
   extra \n



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang merged pull request #8117: [INLONG-8116][Sort] Support table api config setting

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #8117:
URL: https://github.com/apache/inlong/pull/8117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang commented on pull request #8117: [INLONG-8116][Sort] Support table api config setting

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #8117:
URL: https://github.com/apache/inlong/pull/8117#issuecomment-1568213312

   Please rebase from the master to fix the failed UT after https://github.com/apache/inlong/pull/8128 is merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org