You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:03:04 UTC

[GitHub] [spark] srowen commented on pull request #28663: [SPARK-31853][DOCS] Mention removal of params mixins setter in migration guide

srowen commented on pull request #28663:
URL: https://github.com/apache/spark/pull/28663#issuecomment-637017978


   Yeah the only downside is that if we fill the migration guide with a bunch of niche stuff, it might be hard to figure out what the important common items are. I'm not sure how much user code uses the mixins directly, but if there is any code that does it's probably something like `HasOutputCols`, a common one. So yeah I think it's OK to mention this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org