You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "pussuw (via GitHub)" <gi...@apache.org> on 2023/01/27 09:59:43 UTC
[GitHub] [nuttx] pussuw opened a new pull request, #8282: sched/group: Implement group_drop()
pussuw opened a new pull request, #8282:
URL: https://github.com/apache/nuttx/pull/8282
## Summary
Implement a function for dropping references to the group structure and finally freeing the allocated memory, if the group has been marked for destruction. Simplifies logic to hold on to the group structure if the memory is still needed.
## Impact
Cosmetic
## Testing
icicle:knsh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on a diff in pull request #8282: sched/group: Implement group_drop()
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on code in PR #8282:
URL: https://github.com/apache/nuttx/pull/8282#discussion_r1088882402
##########
sched/group/group_leave.c:
##########
@@ -390,3 +380,49 @@ void group_leave(FAR struct tcb_s *tcb)
}
#endif /* HAVE_GROUP_MEMBERS */
+
+/****************************************************************************
+ * Name: group_drop
+ *
+ * Description:
+ * Release the group's memory. This function is called whenever a reference
+ * to the group structure is released. It is not dependent on member count,
+ * but rather external references, which include:
+ * - Waiter list for waitpid()
+ *
+ * Input Parameters:
+ * group - The group that is to be dropped
+ *
+ * Returned Value:
+ * None.
+ *
+ * Assumptions:
+ * Called during task deletion or context switch in a safe context. No
+ * special precautions are required here.
+ *
+ ****************************************************************************/
+
+void group_drop(FAR struct task_group_s *group)
+{
+#if defined(CONFIG_SCHED_WAITPID) && !defined(CONFIG_SCHED_HAVE_PARENT)
+ /* If there are threads waiting for this group to be freed, then we cannot
+ * yet free the memory resources. Instead just mark the group deleted
+ * and wait for those threads complete their waits.
+ */
+
+ if (group->tg_nwaiters > 0)
+ {
+ /* Hold the group still */
Review Comment:
Maybe some debug message explaining that the group wasn't deleted because there are some threads waiting it to be freed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pussuw commented on a diff in pull request #8282: sched/group: Implement group_drop()
Posted by "pussuw (via GitHub)" <gi...@apache.org>.
pussuw commented on code in PR #8282:
URL: https://github.com/apache/nuttx/pull/8282#discussion_r1088886435
##########
sched/group/group_leave.c:
##########
@@ -390,3 +380,49 @@ void group_leave(FAR struct tcb_s *tcb)
}
#endif /* HAVE_GROUP_MEMBERS */
+
+/****************************************************************************
+ * Name: group_drop
+ *
+ * Description:
+ * Release the group's memory. This function is called whenever a reference
+ * to the group structure is released. It is not dependent on member count,
+ * but rather external references, which include:
+ * - Waiter list for waitpid()
+ *
+ * Input Parameters:
+ * group - The group that is to be dropped
+ *
+ * Returned Value:
+ * None.
+ *
+ * Assumptions:
+ * Called during task deletion or context switch in a safe context. No
+ * special precautions are required here.
+ *
+ ****************************************************************************/
+
+void group_drop(FAR struct task_group_s *group)
+{
+#if defined(CONFIG_SCHED_WAITPID) && !defined(CONFIG_SCHED_HAVE_PARENT)
+ /* If there are threads waiting for this group to be freed, then we cannot
+ * yet free the memory resources. Instead just mark the group deleted
+ * and wait for those threads complete their waits.
+ */
+
+ if (group->tg_nwaiters > 0)
+ {
+ /* Hold the group still */
Review Comment:
Good idea, I'll add a message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8282: sched/group: Implement group_drop()
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8282:
URL: https://github.com/apache/nuttx/pull/8282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org