You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 18:25:09 UTC
[GitHub] [spark] peter-toth opened a new pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
peter-toth opened a new pull request #34082:
URL: https://github.com/apache/spark/pull/34082
### What changes were proposed in this pull request?
This reverts commit 866df69c6290b2f8e2726f1325969d23c938c0f2.
### Why are the changes needed?
After the change environment variables were not substituted in user classpath entries. Please find an example on SPARK-35672.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926158712
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926189829
**[Test build #143563 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143563/testReport)** for PR 34082 at commit [`8f557d7`](https://github.com/apache/spark/commit/8f557d7e3d6ca1ac64ebadea5bbe5b588b79fd80).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279948
@peter-toth, it has a conflict on branch-3.2. It seems trivial but I think we should better make a PR since we will release right away. mind creating a backporting Pr please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926287801
Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279069
yeah, let's revert it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926077801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926079966
**[Test build #143563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143563/testReport)** for PR 34082 at commit [`8f557d7`](https://github.com/apache/spark/commit/8f557d7e3d6ca1ac64ebadea5bbe5b588b79fd80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926158770
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926280060
Yeah let's revert it now and fix it later.
Thank you @peter-toth
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279402
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926053474
**[Test build #143562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143562/testReport)** for PR 34082 at commit [`5ae2d9a`](https://github.com/apache/spark/commit/5ae2d9a9368530bcad272ee1c1fb85fb986162d6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926089644
Ack, let me see if I can get at least a POC fix-forward up by today, and if we think it looks good we can continue with that approach. If I'm not able to get something up by today, we revert to unblock the RC. Sound okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926060354
**[Test build #143562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143562/testReport)** for PR 34082 at commit [`5ae2d9a`](https://github.com/apache/spark/commit/5ae2d9a9368530bcad272ee1c1fb85fb986162d6).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279187
cc @gengliangwang . I think it has to go through up to branch-3.1. Just saw https://github.com/apache/spark/pull/34082#issuecomment-926057212 :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926195437
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143563/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926079966
**[Test build #143563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143563/testReport)** for PR 34082 at commit [`8f557d7`](https://github.com/apache/spark/commit/8f557d7e3d6ca1ac64ebadea5bbe5b588b79fd80).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926230826
Put up #34084, PTAL folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34082:
URL: https://github.com/apache/spark/pull/34082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926077801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926195437
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143563/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279007
oh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279402
Merged to master, branch-3.2 and branch-3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926122412
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926053280
cc @xkrogen, @tgravescs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279187
cc @gengliangwang . I think it has to go through up to branch-3.1. EDIT: just saw https://github.com/apache/spark/pull/34082#issuecomment-926057212 :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926285653
I created a backport PR in https://github.com/apache/spark/pull/34088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
peter-toth commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926083563
> I'm interested in fixing-forward -- either hiding this behind a feature flag, or adding logic to handle environment variables when extracting the values from the conf. I don't think either approach would require much time (could be completed by, say, tomorrow), but I understand if there is a desire to revert given that we are already in RC phase.
I'm open to other kind of fixes, just wanted to unblock RCs quickly with this revert...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926057212
Note we will need to revert from the spark 3.1 branch as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926066729
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48071/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926279187
cc @gengliangwang . I think it has to go through up to branch-3.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926053474
**[Test build #143562 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143562/testReport)** for PR 34082 at commit [`5ae2d9a`](https://github.com/apache/spark/commit/5ae2d9a9368530bcad272ee1c1fb85fb986162d6).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926068031
Thanks for reporting this @peter-toth !
From a technical perspective the revert LGTM.
I'm interested in fixing-forward -- either hiding this behind a feature flag, or adding logic to handle environment variables when extracting the values from the conf. I don't think either approach would require much time (could be completed by, say, tomorrow), but I understand if there is a desire to revert given that we are already in RC phase.
cc @mridulm as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34082: Revert "[SPARK-35672][CORE][YARN] Pass user classpath entries to executors using config instead of command line"
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34082:
URL: https://github.com/apache/spark/pull/34082#issuecomment-926158770
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48072/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org