You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/26 10:53:57 UTC

[GitHub] [calcite] vlsi commented on a change in pull request #2356: [CALCITE-4510] RexLiteral can produce wrong digest for some user defined types

vlsi commented on a change in pull request #2356:
URL: https://github.com/apache/calcite/pull/2356#discussion_r583553701



##########
File path: core/src/main/java/org/apache/calcite/rel/type/RelDataType.java
##########
@@ -40,6 +40,11 @@
   int SCALE_NOT_SPECIFIED = Integer.MIN_VALUE;
   int PRECISION_NOT_SPECIFIED = -1;
 
+  /**
+   * Suffix for the digests of non-nullable types.
+   */
+  String NON_NULLABLE_TYPE_DIGEST_SUFFIX = " NOT NULL";

Review comment:
       Frankly speaking, I do not like how this leaks to the public API.
   Could you declare the constant in a Calcite-private location to prevent it accidental use in the client code?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org