You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Amogh Vasekar <am...@citrix.com> on 2014/03/10 20:22:49 UTC
Review Request 18978: Ability to manipulate guest OS mappings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
Repository: cloudstack-git
Description
-------
Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
Diffs
-----
api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
Diff: https://reviews.apache.org/r/18978/diff/
Testing
-------
Tested on local environment on master branch for all APIs, including some edge cases.
Thanks,
Amogh Vasekar
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review37020
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On March 12, 2014, 6:48 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18978/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 6:48 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
> The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
>
>
> Diffs
> -----
>
> api/src/com/cloud/event/EventTypes.java a5fc0f0f7d3492fc0775b4514e4a9f506acb1ed7
> api/src/com/cloud/server/ManagementService.java 5fcf0b5fc5279193db4147607e9919433b2a56db
> api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
> api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
> api/src/org/apache/cloudstack/api/ApiCommandJobType.java f27f001f868ffb0b8315f5468e67d2ec67db4306
> api/src/org/apache/cloudstack/api/ApiConstants.java 0a3fafda312ab72fea96928e68e37f25790e431c
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
> client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
> engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
> engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
> server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
> server/src/com/cloud/server/ManagementServer.java 3b5f5ff206a28acaca964b0b4efeeb30c8c05da8
> server/src/com/cloud/server/ManagementServerImpl.java 663d4e505c5ff7acb215143bdf67f2e114912710
> setup/db/db/schema-430to440.sql ee4cf215fb777fcd46c5715d2b21ffe157692e2a
>
> Diff: https://reviews.apache.org/r/18978/diff/
>
>
> Testing
> -------
>
> Tested on local environment on master branch for the APIs, including some edge cases.
> Ran with findbugs and RAT to ensure no errors in added code
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
-----------------------------------------------------------
(Updated March 12, 2014, 6:48 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Rebased to latest master
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
Repository: cloudstack-git
Description
-------
Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
Diffs (updated)
-----
api/src/com/cloud/event/EventTypes.java a5fc0f0f7d3492fc0775b4514e4a9f506acb1ed7
api/src/com/cloud/server/ManagementService.java 5fcf0b5fc5279193db4147607e9919433b2a56db
api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
api/src/org/apache/cloudstack/api/ApiCommandJobType.java f27f001f868ffb0b8315f5468e67d2ec67db4306
api/src/org/apache/cloudstack/api/ApiConstants.java 0a3fafda312ab72fea96928e68e37f25790e431c
api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
server/src/com/cloud/server/ManagementServer.java 3b5f5ff206a28acaca964b0b4efeeb30c8c05da8
server/src/com/cloud/server/ManagementServerImpl.java 663d4e505c5ff7acb215143bdf67f2e114912710
setup/db/db/schema-430to440.sql ee4cf215fb777fcd46c5715d2b21ffe157692e2a
Diff: https://reviews.apache.org/r/18978/diff/
Testing
-------
Tested on local environment on master branch for the APIs, including some edge cases.
Ran with findbugs and RAT to ensure no errors in added code
Thanks,
Amogh Vasekar
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
-----------------------------------------------------------
(Updated March 11, 2014, 10:38 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Changed APIs to async
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
Repository: cloudstack-git
Description
-------
Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
Diffs (updated)
-----
api/src/com/cloud/event/EventTypes.java 7dd87729d68cb1d4d3cddeec1e337c521e2765be
api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
api/src/org/apache/cloudstack/api/ApiCommandJobType.java 3067af8a528f6318c7ef7fbd08fdbb6b93753305
api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
server/src/com/cloud/server/ManagementServer.java 3b5f5ff206a28acaca964b0b4efeeb30c8c05da8
server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
Diff: https://reviews.apache.org/r/18978/diff/
Testing (updated)
-------
Tested on local environment on master branch for the APIs, including some edge cases.
Ran with findbugs and RAT to ensure no errors in added code
Thanks,
Amogh Vasekar
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Amogh Vasekar <am...@citrix.com>.
> On March 11, 2014, 7:04 p.m., Nitin Mehta wrote:
> > api/src/org/apache/cloudstack/api/ApiConstants.java, line 165
> > <https://reviews.apache.org/r/18978/diff/3/?file=516592#file516592line165>
> >
> > Just os is confusing. Rather name it as guestosname and hypervisorguestosname ?
These are legacy names that conform to the existing names.
> On March 11, 2014, 7:04 p.m., Nitin Mehta wrote:
> > api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java, line 37
> > <https://reviews.apache.org/r/18978/diff/3/?file=516595#file516595line37>
> >
> > An option for adding the guest os for all versions ?
This will break the semantics in the following case :
1. Admin adds mappings for all existing versions of hypervisor
2. CS upgrades / supports new version
The DB will not have mapping for new version, and there is no method to find out if the admin had previously added mappings for all versions or only a subset.
> On March 11, 2014, 7:04 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/server/ManagementServerImpl.java, line 2124
> > <https://reviews.apache.org/r/18978/diff/3/?file=516608#file516608line2124>
> >
> > dont you have to check that hypervisor belongs to one of the three types ?
This is for list command. The check exists while adding a new mapping. Specifying an invalid hypervisor in list command will return an empty list
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review36825
-----------------------------------------------------------
On March 11, 2014, 6:47 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18978/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 6:47 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
> The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
> api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
> api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
> api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
> client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
> engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
> engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
> server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
> server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
> setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
>
> Diff: https://reviews.apache.org/r/18978/diff/
>
>
> Testing
> -------
>
> Tested on local environment on master branch for all APIs, including some edge cases.
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review36825
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/ApiConstants.java
<https://reviews.apache.org/r/18978/#comment68007>
Just os is confusing. Rather name it as guestosname and hypervisorguestosname ?
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java
<https://reviews.apache.org/r/18978/#comment68008>
Lets make this as async...In general all the api's except the list api's should be made aysnc.
Check for other commands as well
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java
<https://reviews.apache.org/r/18978/#comment68009>
Add hypervisor values that are supported
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java
<https://reviews.apache.org/r/18978/#comment68010>
An option for adding the guest os for all versions ?
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment68012>
dont you have to check that hypervisor belongs to one of the three types ?
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment68011>
wrong error message ?
- Nitin Mehta
On March 11, 2014, 6:47 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18978/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 6:47 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
> The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
> api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
> api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
> api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
> client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
> engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
> engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
> server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
> server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
> setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
>
> Diff: https://reviews.apache.org/r/18978/diff/
>
>
> Testing
> -------
>
> Tested on local environment on master branch for all APIs, including some edge cases.
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
-----------------------------------------------------------
(Updated March 11, 2014, 6:47 p.m.)
Review request for cloudstack and Nitin Mehta.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
Repository: cloudstack-git
Description
-------
Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
Diffs (updated)
-----
api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
Diff: https://reviews.apache.org/r/18978/diff/
Testing
-------
Tested on local environment on master branch for all APIs, including some edge cases.
Thanks,
Amogh Vasekar
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Amogh Vasekar <am...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/
-----------------------------------------------------------
(Updated March 10, 2014, 8:25 p.m.)
Review request for cloudstack and Nitin Mehta.
Changes
-------
Sorry, uploaded an old diff by mistake.
Request to please review again
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
Repository: cloudstack-git
Description
-------
Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
Diffs (updated)
-----
api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
Diff: https://reviews.apache.org/r/18978/diff/
Testing
-------
Tested on local environment on master branch for all APIs, including some edge cases.
Thanks,
Amogh Vasekar
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Amogh Vasekar <am...@citrix.com>.
> On March 10, 2014, 8:17 p.m., Nitin Mehta wrote:
> > server/src/com/cloud/server/ManagementServerImpl.java, line 2202
> > <https://reviews.apache.org/r/18978/diff/1/?file=515346#file515346line2202>
> >
> > Since this is mandatory this is not required. Check for others as well
Removed all redundant checks.
> On March 10, 2014, 8:17 p.m., Nitin Mehta wrote:
> > setup/db/db/schema-430to440.sql, line 546
> > <https://reviews.apache.org/r/18978/diff/1/?file=515347#file515347line546>
> >
> > hopefully the length is the standard as other tables are using it. Please confirm
Reduced the length to 32 as per hypervisor_capabilities table.
- Amogh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review36694
-----------------------------------------------------------
On March 10, 2014, 8:25 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18978/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 8:25 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
> The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
> api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
> api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
> api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
> client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
> engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
> engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
> server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
> server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
> setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
>
> Diff: https://reviews.apache.org/r/18978/diff/
>
>
> Testing
> -------
>
> Tested on local environment on master branch for all APIs, including some edge cases.
>
>
> Thanks,
>
> Amogh Vasekar
>
>
Re: Review Request 18978: Ability to manipulate guest OS mappings
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18978/#review36694
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java
<https://reviews.apache.org/r/18978/#comment67759>
There should be list by the id ?
api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java
<https://reviews.apache.org/r/18978/#comment67749>
Uncomment this.
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java
<https://reviews.apache.org/r/18978/#comment67751>
shouldnt be a string
engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java
<https://reviews.apache.org/r/18978/#comment67750>
Remove this if not required
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment67752>
why the like thing ?
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment67753>
Since this is mandatory this is not required. Check for others as well
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment67754>
Put this in DaoImpl
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment67755>
Add in the logging - "make sure the name is unique"
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment67756>
put in .remove() - cant leave for the TODO
server/src/com/cloud/server/ManagementServerImpl.java
<https://reviews.apache.org/r/18978/#comment67757>
Probably add a bit more info...that this is preset and cant be removed, though since its admin only I think it should be fine...say he doesnt want the windows vms to be deployed
setup/db/db/schema-430to440.sql
<https://reviews.apache.org/r/18978/#comment67758>
hopefully the length is the standard as other tables are using it. Please confirm
- Nitin Mehta
On March 10, 2014, 7:22 p.m., Amogh Vasekar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18978/
> -----------------------------------------------------------
>
> (Updated March 10, 2014, 7:22 p.m.)
>
>
> Review request for cloudstack and Nitin Mehta.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6217
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6217
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Add APIs for ability to add new guest OS types, and their hypervisor specific mappings.
> The table guest_os_hypervisor is currently maintained but not used, and the APIs reuse the same.
>
>
> Diffs
> -----
>
> api/src/com/cloud/server/ManagementService.java 24fad87ea0f0b8b76137d85bbdb325c4821b9722
> api/src/com/cloud/storage/GuestOS.java 437cd37d1abaf131e09a294dfabbfe9e901af596
> api/src/com/cloud/storage/GuestOSHypervisor.java f022722af04331b3feb9562683efa384b0ce5676
> api/src/org/apache/cloudstack/api/ApiConstants.java 7b7f9ca6012de11d7887a9c3d32dc79932552969
> api/src/org/apache/cloudstack/api/ResponseGenerator.java 1cb53886a7cd4262f6d5636af6679a17f6a86dcd
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/AddGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/ListGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/RemoveGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/command/admin/guest/UpdateGuestOsMappingCmd.java PRE-CREATION
> api/src/org/apache/cloudstack/api/response/GuestOsMappingResponse.java PRE-CREATION
> client/tomcatconf/commands.properties.in 879c58d63425369eb411325bf6d2fb9d7de9d77a
> engine/schema/src/com/cloud/storage/GuestOSHypervisorVO.java 8210abf8c3d3becdc2b7d092a382f4b06123b7dd
> engine/schema/src/com/cloud/storage/GuestOSVO.java 57b852953a9fe4caae31043b8a63e1df2ff28f9b
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDao.java 651cfb56700857669fcfffd6b134358d2c4bb044
> engine/schema/src/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java be680dc3a50830a9cd17b5cd203cdbc2db3e8936
> server/src/com/cloud/api/ApiResponseHelper.java 81bfe21ee819130957a6d3826417c1fdd4deba79
> server/src/com/cloud/server/ManagementServerImpl.java 62faafc68b31a7612b9280741af6f6f0d9759bf3
> setup/db/db/schema-430to440.sql 0ded7a97fd9d0a50fc0c1efd490feb635c0f27f2
>
> Diff: https://reviews.apache.org/r/18978/diff/
>
>
> Testing
> -------
>
> Tested on local environment on master branch for all APIs, including some edge cases.
>
>
> Thanks,
>
> Amogh Vasekar
>
>