You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/30 08:06:30 UTC

[GitHub] [beam] TobKed commented on a change in pull request #12318: [BEAM-8665] Add test suites to run Beam tests on Linux/Windows/Mac platforms.

TobKed commented on a change in pull request #12318:
URL: https://github.com/apache/beam/pull/12318#discussion_r497319272



##########
File path: sdks/python/apache_beam/runners/portability/stager_test.py
##########
@@ -167,6 +167,9 @@ def test_no_main_session(self):
 
   # xdist adds unpicklable modules to the main session.
   @pytest.mark.no_xdist
+  @pytest.mark.skip(
+      sys.platform == 'win32',
+      "Windows raise TypeError: can't pickle zipimport.zipimporter objects")

Review comment:
       I see it this skip was not included in https://github.com/apache/beam/pull/12452.
   As far i remember after some rebasings and further work on the tests it started to work and for many test runs it didn't fail so I removed this skip.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org