You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/08/05 05:00:41 UTC
[GitHub] [cordova-android] ebhsgit opened a new pull request #1311: [Android] Added support for BoM imports
ebhsgit opened a new pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
A cordova plugin could use BoM to manage the versions of multiple imports.
https://docs.gradle.org/current/userguide/platforms.html#sub:bom_import
Currently there is no way to implement this.
- Package import can not be defined without a version defined
- No ability to import BoM platform
Example using Firebase BoM
https://firebase.google.com/docs/android/learn-more#bom
### Description
<!-- Describe your changes in detail -->
- `propertiesObj.systemLibs` regex - exclude any imports that contains `(` in it's package name
- Added `propertiesObj.bomPlatforms` - any value package which matches `platform("...")`
- Allow package to be imported without version. This will generate a warning in the console
### Testing
<!-- Please describe in detail how you tested your changes. -->
I was able to compile my project (with custom plugin) which uses Firebase BoM
### Checklist
- [ x ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ x ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1311: [Android] Added support for BoM imports
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311#issuecomment-893168128
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1311](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (250557f) into [master](https://codecov.io/gh/apache/cordova-android/commit/5db850890d5c94f5fc3c0b90a02bfb0b251c0da1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5db8508) will **decrease** coverage by `0.24%`.
> The diff coverage is `14.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 73.25% 73.00% -0.25%
==========================================
Files 21 21
Lines 1645 1652 +7
==========================================
+ Hits 1205 1206 +1
- Misses 440 446 +6
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkZXJzL1Byb2plY3RCdWlsZGVyLmpz) | `70.37% <14.28%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5db8508...250557f](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1311: [Android] Added support for BoM imports
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311#issuecomment-893168128
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1311](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (250557f) into [master](https://codecov.io/gh/apache/cordova-android/commit/5db850890d5c94f5fc3c0b90a02bfb0b251c0da1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5db8508) will **decrease** coverage by `0.24%`.
> The diff coverage is `14.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 73.25% 73.00% -0.25%
==========================================
Files 21 21
Lines 1645 1652 +7
==========================================
+ Hits 1205 1206 +1
- Misses 440 446 +6
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkZXJzL1Byb2plY3RCdWlsZGVyLmpz) | `70.37% <14.28%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5db8508...250557f](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ebhsgit commented on pull request #1311: [Android] Added support for BoM imports
Posted by GitBox <gi...@apache.org>.
ebhsgit commented on pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311#issuecomment-915651575
@PieterVanPoyer No problems
Below is the key snippet that this PR would enable
```
<platform name="android">
// Other stuff
<preference name="FIREBASE_BOM" default="28.3.0" />
<framework src="platform('com.google.firebase:firebase-bom:$FIREBASE_BOM')" />
<framework src="com.google.firebase:firebase-auth" />
<framework src="com.google.firebase:firebase-firestore"/>
<framework src="com.google.firebase:firebase-messaging"/>
// Other stuff
</platform>
```
I've attached an example plugin.xml which enables firebase dependencies using BoM
[plugin.zip](https://github.com/apache/cordova-android/files/7132376/plugin.zip)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1311: [Android] Added support for BoM imports
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311#issuecomment-893168128
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1311](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (250557f) into [master](https://codecov.io/gh/apache/cordova-android/commit/5db850890d5c94f5fc3c0b90a02bfb0b251c0da1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5db8508) will **decrease** coverage by `0.24%`.
> The diff coverage is `14.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 73.25% 73.00% -0.25%
==========================================
Files 21 21
Lines 1645 1652 +7
==========================================
+ Hits 1205 1206 +1
- Misses 440 446 +6
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkZXJzL1Byb2plY3RCdWlsZGVyLmpz) | `70.37% <14.28%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5db8508...250557f](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1311: [Android] Added support for BoM imports
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311#issuecomment-893168128
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1311](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (250557f) into [master](https://codecov.io/gh/apache/cordova-android/commit/5db850890d5c94f5fc3c0b90a02bfb0b251c0da1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5db8508) will **decrease** coverage by `0.24%`.
> The diff coverage is `14.28%`.
[](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1311 +/- ##
==========================================
- Coverage 73.25% 73.00% -0.25%
==========================================
Files 21 21
Lines 1645 1652 +7
==========================================
+ Hits 1205 1206 +1
- Misses 440 446 +6
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1311/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliL2J1aWxkZXJzL1Byb2plY3RCdWlsZGVyLmpz) | `70.37% <14.28%> (-2.54%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5db8508...250557f](https://codecov.io/gh/apache/cordova-android/pull/1311?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] ebhsgit commented on pull request #1311: [Android] Added support for BoM imports
Posted by GitBox <gi...@apache.org>.
ebhsgit commented on pull request #1311:
URL: https://github.com/apache/cordova-android/pull/1311#issuecomment-900033426
@breautek
Hi mate, Any way to get someone to review the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org