[GitHub] [iceberg] hankfanchiu commented on pull request #3043: Revert #2960 and commit no-op partition replacement operations

[GitBox <gi...@apache.org>]

hankfanchiu commented on pull request #3043:
URL: https://github.com/apache/iceberg/pull/3043#issuecomment-914637027


   > we need to add a new table option, and check it on whether or not to make the commit in the MergingSnapshotProducer apply method.
   
   What would you suggest as the name of this configuration option? How about one of the following?
   
   1. `commit.allow-empty.enabled`, default: `false`
   2. `commit.skip-empty.enabled`, default: `true`
   3. `commit.omit-empty.enabled`, default: `true`
   
   Having the verb first is different than an existing option that has the affected entity followed by the action, i.e. noun and then verb:
   
   https://github.com/apache/iceberg/blob/5f9047602bb23fa4d0f5cf63eea00f38329fb7bf/core/src/main/java/org/apache/iceberg/TableProperties.java#L83-L84
   
   Some other options:
   
   * `empty-allow` or `empty-skip` or `empty-omit` seems unintuitive?
   * `empty-allowed.enabled` or `empty-skipped.enabled` or `empty-omitted.enabled` stutters a bit?
   * `empty.enabled` might be ambiguous?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org