[GitHub] [netbeans-tools] matthiasblaesing edited a comment on issue #15: Implement OAuth2/OpenID based/inspired login flows

[GitBox <gi...@apache.org>]

matthiasblaesing edited a comment on issue #15: Implement OAuth2/OpenID based/inspired login flows
URL: https://github.com/apache/netbeans-tools/pull/15#issuecomment-546629370
 
 
   @jpirek @jkovalsky it would be great if you could have a look at this. This is the PHP implementation of what I prototyped in java and announced on the mailing list in the mail "[PluginPortal] Implement OAuth2 based authentication in PP3?".
   
   I still have a bad feeling using PHP here (see the hack, that was needed to get some sensible error reporting in Module.php), but I think this should work. In fact, I have an experimental setup at:
   
   https://doppel-helix.eu/pp3/
   
   Please note: when this is merged, the database structure needs to be updated and a migration path will be ugly (you can't query the OAuth providers for the userids, you'd need).
   
   For the "how do I see what changed": The part that is visible to the user is the "Login" Button in the top right. There was the "Login with Google" button. You are now taken to a page, where you have to choose which identity provider you want to use.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists