[GitHub] [incubator-superset] dpgaspar commented on pull request #11391: feat: saved queries with execution info

[GitBox <gi...@apache.org>]

dpgaspar commented on pull request #11391:
URL: https://github.com/apache/incubator-superset/pull/11391#issuecomment-716476705


   > Did we consider having this as a foreign key to the query table? There are probably pros/cons here.
   
   @mistercrunch 
   
   I have considered using a custom SQLAlchemy relation on SavedQuery, but I think is not clean since there is no relation between savedqueries and queries, this is kind of an best effort. But more importantly using a relation on savedquery to join query is expensive (since query table grows a lot and we are joining by `sql` text field). 
   I think that this write approach is light and not too "evasive"
   
   Thoughts?  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org