You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2011/07/05 04:49:05 UTC
DO NOT REPLY [Bug 51472] New: Bugin ? in BeanELResolver.getMethod()
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Bug #: 51472
Summary: Bugin ? in BeanELResolver.getMethod()
Product: Tomcat 7
Version: 7.0.16
Platform: PC
Status: NEW
Severity: normal
Priority: P2
Component: Servlet & JSP API
AssignedTo: dev@tomcat.apache.org
ReportedBy: friedhelm.kuehn@cms-it-services.de
Classification: Unclassified
BeanResolver.getMethod() starts with:
if (m == null || Modifier.isPublic(type.getModifiers())) {
return m;
}
That tests method existence and whether Class has public modifier.
I think that public Modifier of Method should be tested instead/or
additionally.
So:
if (m == null || Modifier.isPublic(m.getModifiers())) {
return m;
}
Or:
if (m == null || Modifier.isPublic(type.getModifiers()
&& Modifier.isPublic(m.getModifiers())) {
return m;
}
Right ?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51472] Bugin ? in BeanELResolver.getMethod()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
--- Comment #4 from Konstantin Kolinko <kn...@gmail.com> 2011-07-06 08:51:05 UTC ---
(In reply to comment #3)
Yes, as designed.
For reference, the discussion that Mark mentions
http://markmail.org/message/zpyvs4vqj2whqloo
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51472] Bugin ? in BeanELResolver.getMethod()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
--- Comment #2 from Mark Thomas <ma...@apache.org> 2011-07-05 10:43:40 UTC ---
The patch has been reverted from 7.0.x and the proposed patch for 6.0.x
withdrawn.
The analysis is incorrect. The current code is correct. Detailed discussion on
the dev list.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51472] Bugin ? in BeanELResolver.getMethod()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
--- Comment #3 from friedhelm.kuehn@cms-it-services.de 2011-07-05 11:38:50 UTC ---
Sorry for my proposal, in case it is truely not correct.
However, I was not able to get the follwing bean working:
class xyz {
public getAbc(){
...
}
}
because I forgot to explcitly mark the class 'public'.
- getAbc was not defined in an Interface (as normally is)
- getAbc was not defined in superClass
After marking class 'public' it worked.
Works as designed ?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 51472] Bugin ? in BeanELResolver.getMethod()
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Servlet & JSP API |Jasper
Version|7.0.16 |6.0.32
Product|Tomcat 7 |Tomcat 6
Target Milestone|--- |default
OS/Version| |All
--- Comment #1 from Mark Thomas <ma...@apache.org> 2011-07-05 10:05:18 UTC ---
Thanks for the patch.
Fixed in 7.0.x and will be included in 7.0.18 onwards.
Proposed for 6.0.x
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org