You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/10/01 21:18:56 UTC
[I] [Variant] casting functions are confusingly named [arrow-rs]
alamb opened a new issue, #8531:
URL: https://github.com/apache/arrow-rs/issues/8531
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
We have two functions that are inverses of each other that are confusingly named;
* `cast_to_variant` which casts arrow arrays to variant
* `variant_to_arrow` which casts variants to arrow arrays
Further adding to the confusion is that we have modules named `arrow_to_variant` which doesn't contain the casting kernel
**Describe the solution you'd like**
I would like the names to be consistent
**Describe alternatives you've considered**
I propose changing the names of the casting functions to be more explicit:
* `cast_arrow_to_variant`
* `cast_variant_to_arrow`
And leaving the conversion code in the modules `arrow_to_variant` and `variant_to_arrow`
**Additional context**
Came up with conversation with @scovich on
- https://github.com/apache/arrow-rs/pull/8521/commits/509d43244eec3924659e61abba37adc83a9f2118#r2393067849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Variant] casting functions are confusingly named [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8531:
URL: https://github.com/apache/arrow-rs/issues/8531#issuecomment-3416681819
`label_issue.py` automatically added labels {'parquet-variant'} from #8536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Variant] casting functions are confusingly named [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8531:
URL: https://github.com/apache/arrow-rs/issues/8531#issuecomment-3358200681
Actually, I am going crazy -- there is no `variant_to_arrow`, instaed that is done by `variant_get`
I will make this clearer in docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Variant] casting functions are confusingly named [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #8531: [Variant] casting functions are confusingly named
URL: https://github.com/apache/arrow-rs/issues/8531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Variant] casting functions are confusingly named [arrow-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #8531:
URL: https://github.com/apache/arrow-rs/issues/8531#issuecomment-3416681637
`label_issue.py` automatically added labels {'parquet'} from #8536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org