You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2004/08/13 17:07:27 UTC

Re: cvs commit: httpd-2.0/modules/proxy proxy_util.c

At 07:20 AM 8/13/2004, trawick@apache.org wrote:
>trawick     2004/08/13 05:20:53
>
>  Modified:    modules/proxy proxy_util.c
>  Log:
>  axe some unused variables and don't log an error code that
>  hasn't been initialized


>  -            ap_log_error(APLOG_MARK, APLOG_ERR, rv, s,
>  +            ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
>                            "proxy: %s: disabled connection for (%s)",
>                            proxy_function, worker->hostname);

Shouldn't that be APLOG_ERR|APLOG_NOERRNO if rv isn't passed?

Bill

Re: cvs commit: httpd-2.0/modules/proxy proxy_util.c

Posted by Jeff Trawick <tr...@gmail.com>.

On Fri, 13 Aug 2004 10:07:27 -0500, William A. Rowe, Jr.
<wr...@rowe-clan.net> wrote:
> At 07:20 AM 8/13/2004, trawick@apache.org wrote:
> >trawick     2004/08/13 05:20:53
> >
> >  Modified:    modules/proxy proxy_util.c
> >  Log:
> >  axe some unused variables and don't log an error code that
> >  hasn't been initialized
> 
> >  -            ap_log_error(APLOG_MARK, APLOG_ERR, rv, s,
> >  +            ap_log_error(APLOG_MARK, APLOG_ERR, 0, s,
> >                            "proxy: %s: disabled connection for (%s)",
> >                            proxy_function, worker->hostname);
> 
> Shouldn't that be APLOG_ERR|APLOG_NOERRNO if rv isn't passed?

no.  1.3 required APLOG_NOERRNO so that it didn't look at errno;

the natural logic of formatting the error information when the
apr_status_t parameter is non-APR_SUCCESS is what is used

APLOG_NOERRNO is still defined but has no effect