You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@bookkeeper.apache.org by gi...@git.apache.org on 2017/07/04 11:47:33 UTC

[GitHub] sigee opened a new pull request #231: Issue 230: Add Checkstyle to the build process (Part 1)

sigee opened a new pull request #231: Issue 230: Add Checkstyle to the build process (Part 1)
URL: https://github.com/apache/bookkeeper/pull/231
 
 
   Add checkstyle to
   - bookkeeper-benchmark
   - Stats API for bookkeeper
   - Stats provider for codahale metrics
   - Stats provider for Prometheus
   - Stats provider for Finagle stats
   - Stats provider for twitter-ostrich package
   - Stats provider for twitter-stats package
   
   and fix issues checkstyle reported.
   
   ---
   Be sure to do all of the following to help us incorporate your contribution
   quickly and easily:
   
   - [X] Make sure the PR title is formatted like:
       `<Issue # or BOOKKEEPER-#>: Description of pull request`
       `e.g. Issue 123: Description ...`
       `e.g. BOOKKEEPER-1234: Description ...`
   - [ ] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
   - [X] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
   
   ---
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services