You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/11/25 22:04:37 UTC
[GitHub] [nifi] simonbence opened a new pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
simonbence opened a new pull request #4689:
URL: https://github.com/apache/nifi/pull/4689
[NIFI-8039](https://issues.apache.org/jira/browse/NIFI-8039)
Current implementation of ListenTCP might consume high amount of resources at processor initialisation and keeps them acquired regardless the load. My proposal contains changes in order to mitigate this. These includes:
- Replacement of the fixed thread pool into a more scalable one
- The opportunity to create byte buffers ad hod instead of pooling high number of instances
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r531734236
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/SocketChannelDispatcher.java
##########
@@ -52,61 +53,80 @@
private final EventFactory<E> eventFactory;
private final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory;
- private final BlockingQueue<ByteBuffer> bufferPool;
+ private final ByteBufferSource bufferSource;
private final BlockingQueue<E> events;
private final ComponentLog logger;
private final int maxConnections;
+ private final int maxThreadPoolSize;
private final SSLContext sslContext;
private final ClientAuth clientAuth;
private final Charset charset;
- private ExecutorService executor;
+ private ThreadPoolExecutor executor;
private volatile boolean stopped = false;
private Selector selector;
private final BlockingQueue<SelectionKey> keyQueue;
private final AtomicInteger currentConnections = new AtomicInteger(0);
public SocketChannelDispatcher(final EventFactory<E> eventFactory,
final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
- final BlockingQueue<ByteBuffer> bufferPool,
+ final ByteBufferSource bufferSource,
+ final BlockingQueue<E> events,
+ final ComponentLog logger,
+ final int maxConnections,
+ final SSLContext sslContext,
+ final Charset charset) {
+ this(eventFactory, handlerFactory, bufferSource, events, logger, maxConnections, sslContext, ClientAuth.REQUIRED, charset);
+ }
+
+ public SocketChannelDispatcher(final EventFactory<E> eventFactory,
+ final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
+ final ByteBufferSource bufferSource,
final BlockingQueue<E> events,
final ComponentLog logger,
final int maxConnections,
final SSLContext sslContext,
+ final ClientAuth clientAuth,
final Charset charset) {
- this(eventFactory, handlerFactory, bufferPool, events, logger, maxConnections, sslContext, ClientAuth.REQUIRED, charset);
+ this(eventFactory, handlerFactory, bufferSource, events, logger, maxConnections, maxConnections, sslContext, clientAuth, charset);
}
public SocketChannelDispatcher(final EventFactory<E> eventFactory,
final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
- final BlockingQueue<ByteBuffer> bufferPool,
+ final ByteBufferSource bufferSource,
final BlockingQueue<E> events,
final ComponentLog logger,
final int maxConnections,
+ final int maxThreadPoolSize,
final SSLContext sslContext,
final ClientAuth clientAuth,
final Charset charset) {
this.eventFactory = eventFactory;
this.handlerFactory = handlerFactory;
- this.bufferPool = bufferPool;
+ this.bufferSource = bufferSource;
this.events = events;
this.logger = logger;
this.maxConnections = maxConnections;
+ this.maxThreadPoolSize = maxThreadPoolSize;
this.keyQueue = new LinkedBlockingQueue<>(maxConnections);
this.sslContext = sslContext;
this.clientAuth = clientAuth;
this.charset = charset;
-
- if (bufferPool == null || bufferPool.size() == 0 || bufferPool.size() != maxConnections) {
- throw new IllegalArgumentException(
- "A pool of available ByteBuffers equal to the maximum number of connections is required");
- }
}
@Override
public void open(final InetAddress nicAddress, final int port, final int maxBufferSize) throws IOException {
+ final InetSocketAddress inetSocketAddress = new InetSocketAddress(nicAddress, port);
+
stopped = false;
- executor = Executors.newFixedThreadPool(maxConnections);
+ executor = new ThreadPoolExecutor(
+ maxThreadPoolSize,
+ maxThreadPoolSize,
+ 60L,
+ TimeUnit.SECONDS,
+ new LinkedBlockingQueue<>(),
+ new BasicThreadFactory.Builder().namingPattern(inetSocketAddress.toString() + "-dispatcher-%d").build());
Review comment:
These are "worker" threads started by the dispatcher so "-worker" would be the appropriate suffix.
Regarding the prefix: It is more typical to use the processor's (class)name + id like in case of the dispatcher thread: https://github.com/apache/nifi/blob/fe950131c35756dabd677fb21b436a1f85eabced/nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/AbstractListenEventProcessor.java#L198
It would be better to link the dispatcher and the worker threads together via a same naming convention (eg. to make troubleshooting easier).
I see that the processor's attributes are not available here right now so this change would not be straightforward.
I would suggest reverting it back to the original logic (default pool-x-thread-y) and solving it when the other listen processors are getting fixed.
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/ByteBufferSource.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processor.util.listen.dispatcher;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Manages byte buffers for the dispatchers.
+ */
+public interface ByteBufferSource {
+
+ /**
+ * @return Returns for a buffer for usage. The buffer can be pooled or created on demand depending on the implementation.
Review comment:
"Returns a buffer..."
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java
##########
@@ -83,10 +87,37 @@
.defaultValue(ClientAuth.REQUIRED.name())
.build();
+ public static final PropertyDescriptor MAX_RECV_THREAD_POOL_SIZE = new PropertyDescriptor.Builder()
+ .name("max-receiving-threads")
+ .displayName("Max Number of Receiving Message Handler Threads")
+ .description(
+ "The maximum number of threads might be available for handling receiving messages ready all the time. " +
+ "Cannot be bigger than the \"Max Number of TCP Connections\". " +
+ "If not set, the value of \"Max Number of TCP Connections\" will be used.")
+ .addValidator(StandardValidators.createLongValidator(1, 65535, true))
+ .required(false)
+ .build();
+
+ protected static final PropertyDescriptor POOL_RECV_BUFFERS = new PropertyDescriptor.Builder()
+ .name("pool-receive-buffers")
+ .displayName("Pool Receive Buffers")
+ .description(
+ "When turned on, the processor uses pre-populated pool of buffers when receiving messages. " +
+ "This is prepared during initialisation of the processor. " +
+ "With high value of Max Number of TCP Connections and Receive Buffer Size this strategy might allocate significant amount of memory! " +
+ "When turned off, the byte buffers will be created ad hoc.")
Review comment:
"will be created on demand and be destroyed after use."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
simonbence commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r531040364
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/ByteBufferSource.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processor.util.listen.dispatcher;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Manages byte buffers for the dispatchers.
+ */
+public interface ByteBufferSource {
+
+ /**
+ * @return Returns for a buffer for usage. It is not guaranteed tha the buffer is created ad hoc. If the source is
+ * not capable to provide an instance, it returns {@code null} instead.
+ */
+ ByteBuffer acquireBuffer();
+
+ /**
+ * With calling this method the client releases the buffer. It might be reused by the handler and not to be used
+ * by this client any more.
+ *
+ * @param byteBuffer The byte buffer the client acquired previously.
+ */
+ void release(ByteBuffer byteBuffer);
Review comment:
Good point, it's some inconsistency remained in the naming during some change, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
simonbence commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r532059585
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/SocketChannelDispatcher.java
##########
@@ -52,61 +53,80 @@
private final EventFactory<E> eventFactory;
private final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory;
- private final BlockingQueue<ByteBuffer> bufferPool;
+ private final ByteBufferSource bufferSource;
private final BlockingQueue<E> events;
private final ComponentLog logger;
private final int maxConnections;
+ private final int maxThreadPoolSize;
private final SSLContext sslContext;
private final ClientAuth clientAuth;
private final Charset charset;
- private ExecutorService executor;
+ private ThreadPoolExecutor executor;
private volatile boolean stopped = false;
private Selector selector;
private final BlockingQueue<SelectionKey> keyQueue;
private final AtomicInteger currentConnections = new AtomicInteger(0);
public SocketChannelDispatcher(final EventFactory<E> eventFactory,
final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
- final BlockingQueue<ByteBuffer> bufferPool,
+ final ByteBufferSource bufferSource,
+ final BlockingQueue<E> events,
+ final ComponentLog logger,
+ final int maxConnections,
+ final SSLContext sslContext,
+ final Charset charset) {
+ this(eventFactory, handlerFactory, bufferSource, events, logger, maxConnections, sslContext, ClientAuth.REQUIRED, charset);
+ }
+
+ public SocketChannelDispatcher(final EventFactory<E> eventFactory,
+ final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
+ final ByteBufferSource bufferSource,
final BlockingQueue<E> events,
final ComponentLog logger,
final int maxConnections,
final SSLContext sslContext,
+ final ClientAuth clientAuth,
final Charset charset) {
- this(eventFactory, handlerFactory, bufferPool, events, logger, maxConnections, sslContext, ClientAuth.REQUIRED, charset);
+ this(eventFactory, handlerFactory, bufferSource, events, logger, maxConnections, maxConnections, sslContext, clientAuth, charset);
}
public SocketChannelDispatcher(final EventFactory<E> eventFactory,
final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
- final BlockingQueue<ByteBuffer> bufferPool,
+ final ByteBufferSource bufferSource,
final BlockingQueue<E> events,
final ComponentLog logger,
final int maxConnections,
+ final int maxThreadPoolSize,
final SSLContext sslContext,
final ClientAuth clientAuth,
final Charset charset) {
this.eventFactory = eventFactory;
this.handlerFactory = handlerFactory;
- this.bufferPool = bufferPool;
+ this.bufferSource = bufferSource;
this.events = events;
this.logger = logger;
this.maxConnections = maxConnections;
+ this.maxThreadPoolSize = maxThreadPoolSize;
this.keyQueue = new LinkedBlockingQueue<>(maxConnections);
this.sslContext = sslContext;
this.clientAuth = clientAuth;
this.charset = charset;
-
- if (bufferPool == null || bufferPool.size() == 0 || bufferPool.size() != maxConnections) {
- throw new IllegalArgumentException(
- "A pool of available ByteBuffers equal to the maximum number of connections is required");
- }
}
@Override
public void open(final InetAddress nicAddress, final int port, final int maxBufferSize) throws IOException {
+ final InetSocketAddress inetSocketAddress = new InetSocketAddress(nicAddress, port);
+
stopped = false;
- executor = Executors.newFixedThreadPool(maxConnections);
+ executor = new ThreadPoolExecutor(
+ maxThreadPoolSize,
+ maxThreadPoolSize,
+ 60L,
+ TimeUnit.SECONDS,
+ new LinkedBlockingQueue<>(),
+ new BasicThreadFactory.Builder().namingPattern(inetSocketAddress.toString() + "-dispatcher-%d").build());
Review comment:
Yes, the decision was made due to the processor attributes are not available here. Also, I decided to change the default value to make it easier to follow the threads in case multiple ListenTCP processors are in the flow. By adding the address, it is easy to identify which processor it is related to which adding the class does not help. I am aware of that this is not following the general convention but due to the possible multiplication of the pools it makes sense to me. Adding the class as prefix as well might work but it might be too long. For now I went with a common ground type of solution and replaced dispatcher postfix with worker. For the prefix I intend to keep it, expect you insist to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r532445464
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/SocketChannelDispatcher.java
##########
@@ -52,61 +53,80 @@
private final EventFactory<E> eventFactory;
private final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory;
- private final BlockingQueue<ByteBuffer> bufferPool;
+ private final ByteBufferSource bufferSource;
private final BlockingQueue<E> events;
private final ComponentLog logger;
private final int maxConnections;
+ private final int maxThreadPoolSize;
private final SSLContext sslContext;
private final ClientAuth clientAuth;
private final Charset charset;
- private ExecutorService executor;
+ private ThreadPoolExecutor executor;
private volatile boolean stopped = false;
private Selector selector;
private final BlockingQueue<SelectionKey> keyQueue;
private final AtomicInteger currentConnections = new AtomicInteger(0);
public SocketChannelDispatcher(final EventFactory<E> eventFactory,
final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
- final BlockingQueue<ByteBuffer> bufferPool,
+ final ByteBufferSource bufferSource,
+ final BlockingQueue<E> events,
+ final ComponentLog logger,
+ final int maxConnections,
+ final SSLContext sslContext,
+ final Charset charset) {
+ this(eventFactory, handlerFactory, bufferSource, events, logger, maxConnections, sslContext, ClientAuth.REQUIRED, charset);
+ }
+
+ public SocketChannelDispatcher(final EventFactory<E> eventFactory,
+ final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
+ final ByteBufferSource bufferSource,
final BlockingQueue<E> events,
final ComponentLog logger,
final int maxConnections,
final SSLContext sslContext,
+ final ClientAuth clientAuth,
final Charset charset) {
- this(eventFactory, handlerFactory, bufferPool, events, logger, maxConnections, sslContext, ClientAuth.REQUIRED, charset);
+ this(eventFactory, handlerFactory, bufferSource, events, logger, maxConnections, maxConnections, sslContext, clientAuth, charset);
}
public SocketChannelDispatcher(final EventFactory<E> eventFactory,
final ChannelHandlerFactory<E, AsyncChannelDispatcher> handlerFactory,
- final BlockingQueue<ByteBuffer> bufferPool,
+ final ByteBufferSource bufferSource,
final BlockingQueue<E> events,
final ComponentLog logger,
final int maxConnections,
+ final int maxThreadPoolSize,
final SSLContext sslContext,
final ClientAuth clientAuth,
final Charset charset) {
this.eventFactory = eventFactory;
this.handlerFactory = handlerFactory;
- this.bufferPool = bufferPool;
+ this.bufferSource = bufferSource;
this.events = events;
this.logger = logger;
this.maxConnections = maxConnections;
+ this.maxThreadPoolSize = maxThreadPoolSize;
this.keyQueue = new LinkedBlockingQueue<>(maxConnections);
this.sslContext = sslContext;
this.clientAuth = clientAuth;
this.charset = charset;
-
- if (bufferPool == null || bufferPool.size() == 0 || bufferPool.size() != maxConnections) {
- throw new IllegalArgumentException(
- "A pool of available ByteBuffers equal to the maximum number of connections is required");
- }
}
@Override
public void open(final InetAddress nicAddress, final int port, final int maxBufferSize) throws IOException {
+ final InetSocketAddress inetSocketAddress = new InetSocketAddress(nicAddress, port);
+
stopped = false;
- executor = Executors.newFixedThreadPool(maxConnections);
+ executor = new ThreadPoolExecutor(
+ maxThreadPoolSize,
+ maxThreadPoolSize,
+ 60L,
+ TimeUnit.SECONDS,
+ new LinkedBlockingQueue<>(),
+ new BasicThreadFactory.Builder().namingPattern(inetSocketAddress.toString() + "-dispatcher-%d").build());
Review comment:
It is fine with me. Though the network address is not the best but much better than pool-x-thread-y.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] simonbence commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
simonbence commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r531042819
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java
##########
@@ -83,10 +87,49 @@
.defaultValue(ClientAuth.REQUIRED.name())
.build();
+ public static final PropertyDescriptor MIN_RECV_THREAD_POOL_SIZE = new PropertyDescriptor.Builder()
+ .name("min_receiving_threads")
+ .displayName("Min Number of Receiving Message Handler Threads")
+ .description(
+ "The minimum number of threads for handling receiving messages ready all the time. " +
+ "Cannot be bigger than the \"Max Number of Receiving Message Handler Threads\" or \"Max Number of TCP Connections\". " +
+ "If not set, the value of \"Max Number of Receiving Message Handler Threads\" will be used.")
+ .addValidator(StandardValidators.createLongValidator(1, 65535, true))
+ .required(false)
+ .build();
+
+ public static final PropertyDescriptor MAX_RECV_THREAD_POOL_SIZE = new PropertyDescriptor.Builder()
+ .name("max_receiving_threads")
+ .displayName("Max Number of Receiving Message Handler Threads")
+ .description(
+ "The maximum number of threads might be available for handling receiving messages ready all the time. " +
+ "Cannot be bigger than the \"Max Number of TCP Connections\". " +
+ "If not set, the value of \"Max Number of Receiving Message Handler Threads\" will be used.")
+ .addValidator(StandardValidators.createLongValidator(1, 65535, true))
+ .required(false)
+ .build();
+
+ protected static final PropertyDescriptor RECV_POOL_BYTE_BUFFERS = new PropertyDescriptor.Builder()
+ .name("pool_byte_buffers")
+ .displayName("Pool Byte Buffers")
Review comment:
As for the naming, it sounds better I will apply. The order is restricted by the fact that the processor uses a mix of its own properties and the abstract parent's ones with the fashion of an extendable hook point inherited from the parent. Later on, if this change proves itself I plan to applicate it to the other Listen processors, which makes these changes move up to the parent, eliminating this inconsistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4689:
URL: https://github.com/apache/nifi/pull/4689
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a change in pull request #4689: NIFI-8039 Adding properties to ListenTCP in order to allow refine behaviour under higher load; Refining thread pool for better scalability
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on a change in pull request #4689:
URL: https://github.com/apache/nifi/pull/4689#discussion_r531025457
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java
##########
@@ -83,10 +87,49 @@
.defaultValue(ClientAuth.REQUIRED.name())
.build();
+ public static final PropertyDescriptor MIN_RECV_THREAD_POOL_SIZE = new PropertyDescriptor.Builder()
+ .name("min_receiving_threads")
+ .displayName("Min Number of Receiving Message Handler Threads")
+ .description(
+ "The minimum number of threads for handling receiving messages ready all the time. " +
+ "Cannot be bigger than the \"Max Number of Receiving Message Handler Threads\" or \"Max Number of TCP Connections\". " +
+ "If not set, the value of \"Max Number of Receiving Message Handler Threads\" will be used.")
+ .addValidator(StandardValidators.createLongValidator(1, 65535, true))
+ .required(false)
+ .build();
+
+ public static final PropertyDescriptor MAX_RECV_THREAD_POOL_SIZE = new PropertyDescriptor.Builder()
+ .name("max_receiving_threads")
+ .displayName("Max Number of Receiving Message Handler Threads")
+ .description(
+ "The maximum number of threads might be available for handling receiving messages ready all the time. " +
+ "Cannot be bigger than the \"Max Number of TCP Connections\". " +
+ "If not set, the value of \"Max Number of Receiving Message Handler Threads\" will be used.")
+ .addValidator(StandardValidators.createLongValidator(1, 65535, true))
+ .required(false)
+ .build();
+
+ protected static final PropertyDescriptor RECV_POOL_BYTE_BUFFERS = new PropertyDescriptor.Builder()
+ .name("pool_byte_buffers")
+ .displayName("Pool Byte Buffers")
Review comment:
I would call it `Pool Receive Buffers` and move the property just after `Receive Buffer Size` on the UI, and then the receiver threads property.
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenTCP.java
##########
@@ -83,10 +87,49 @@
.defaultValue(ClientAuth.REQUIRED.name())
.build();
+ public static final PropertyDescriptor MIN_RECV_THREAD_POOL_SIZE = new PropertyDescriptor.Builder()
+ .name("min_receiving_threads")
Review comment:
Property names rather use `min-receiving-threads` convention.
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/ByteBufferSource.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processor.util.listen.dispatcher;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Manages byte buffers for the dispatchers.
+ */
+public interface ByteBufferSource {
+
+ /**
+ * @return Returns for a buffer for usage. It is not guaranteed tha the buffer is created ad hoc. If the source is
+ * not capable to provide an instance, it returns {@code null} instead.
+ */
+ ByteBuffer acquireBuffer();
+
+ /**
+ * With calling this method the client releases the buffer. It might be reused by the handler and not to be used
+ * by this client any more.
+ *
+ * @param byteBuffer The byte buffer the client acquired previously.
+ */
+ void release(ByteBuffer byteBuffer);
Review comment:
Is it intentional that one method has "Buffer" suffix but the other does not?
I would use either acquire + release or acquireBuffer + releaseBuffer.
##########
File path: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/ByteBufferSource.java
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processor.util.listen.dispatcher;
+
+import java.nio.ByteBuffer;
+
+/**
+ * Manages byte buffers for the dispatchers.
+ */
+public interface ByteBufferSource {
+
+ /**
+ * @return Returns for a buffer for usage. It is not guaranteed tha the buffer is created ad hoc. If the source is
Review comment:
_"It is not guaranteed tha the buffer is created ad hoc."_
I would rather say: _"The buffer can be pooled or created on demand depending on the implementation."_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org