You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/08/06 06:24:44 UTC

[GitHub] [incubator-iotdb] JulianFeinauer commented on a change in pull request #332: Major cleanup of the maven-build

JulianFeinauer commented on a change in pull request #332: Major cleanup of the maven-build
URL: https://github.com/apache/incubator-iotdb/pull/332#discussion_r310897352
 
 

 ##########
 File path: distribution/pom.xml
 ##########
 @@ -83,4 +83,18 @@
             </plugin>
         </plugins>
     </build>
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.iotdb</groupId>
+            <artifactId>iotdb-server</artifactId>
+            <version>0.9.0-SNAPSHOT</version>
+            <type>zip</type>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.iotdb</groupId>
+            <artifactId>iotdb-client</artifactId>
+            <version>0.9.0-SNAPSHOT</version>
 
 Review comment:
   @jixuan1989 Chris commented in his mail about that and it seems like there is a best practice to do it like that, so I suggest to keep it like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services