You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/30 02:30:45 UTC
[GitHub] [spark] WeichenXu123 opened a new pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
WeichenXu123 opened a new pull request #30539:
URL: https://github.com/apache/spark/pull/30539
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
When saving validator estimatorParamMaps, will check all nested stages in tuned estimator to get correct param parent.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-736160622
Merged to master. It seem that this fix can not be directly backported to branch-3.0. @WeichenXu123
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735696533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] WeichenXu123 commented on a change in pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
WeichenXu123 commented on a change in pull request #30539:
URL: https://github.com/apache/spark/pull/30539#discussion_r532425809
##########
File path: python/pyspark/ml/tests/test_tuning.py
##########
@@ -73,7 +73,21 @@ def test_addGrid(self):
.build())
-class CrossValidatorTests(SparkSessionTestCase):
+class ValidatorTestUtilsMixin:
+ def assert_param_maps_equal(self, paramMaps1, paramMaps2):
+ self.assertEqual(len(paramMaps1), len(paramMaps2))
+ for paramMap1, paramMap2 in zip(paramMaps1, paramMaps2):
+ self.assertEqual(set(paramMap1.keys()), set(paramMap2.keys()))
+ for param in paramMap1.keys():
+ v1 = paramMap1[param]
+ v2 = paramMap2[param]
+ if isinstance(v1, Params):
+ self.assertEqual(v1.uid, v2.uid)
+ else:
+ self.assertEqual(v1, v2)
Review comment:
Add strict verification for param maps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735510854
**[Test build #131946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131946/testReport)** for PR 30539 at commit [`bbe3574`](https://github.com/apache/spark/commit/bbe357423fd328b44a9cf6cd8575d4e4a78c870b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735727291
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735554419
**[Test build #131960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131960/testReport)** for PR 30539 at commit [`3375bf4`](https://github.com/apache/spark/commit/3375bf4e0413954d672f65f494a8c7298c77c599).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735606969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735557930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735522990
**[Test build #131950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131950/testReport)** for PR 30539 at commit [`527ec1a`](https://github.com/apache/spark/commit/527ec1afe362319fe0272ad1564c3ab0118cc374).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] WeichenXu123 commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
WeichenXu123 commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-736142470
> Looks OK - test cleanup looks like a win too. Can the refactored logic be reused anywhere else?
Yes. The MetaAlgorithmReadWrite code will be reused in the PR https://github.com/apache/spark/pull/30471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735839124
**[Test build #131982 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131982/testReport)** for PR 30539 at commit [`f41bd69`](https://github.com/apache/spark/commit/f41bd69e48d366fd7cfaeda1a879bfe6bda05452).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735715720
**[Test build #131976 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131976/testReport)** for PR 30539 at commit [`b1c94cb`](https://github.com/apache/spark/commit/b1c94cbee7541ce9c44c0d2e54072df9c5ba2fff).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735536330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735642271
**[Test build #131976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131976/testReport)** for PR 30539 at commit [`b1c94cb`](https://github.com/apache/spark/commit/b1c94cbee7541ce9c44c0d2e54072df9c5ba2fff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735854073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735511074
**[Test build #131946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131946/testReport)** for PR 30539 at commit [`bbe3574`](https://github.com/apache/spark/commit/bbe357423fd328b44a9cf6cd8575d4e4a78c870b).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735785922
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735557930
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735606969
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735580871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735696533
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735539225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735757227
**[Test build #131982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131982/testReport)** for PR 30539 at commit [`f41bd69`](https://github.com/apache/spark/commit/f41bd69e48d366fd7cfaeda1a879bfe6bda05452).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735554419
**[Test build #131960 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131960/testReport)** for PR 30539 at commit [`3375bf4`](https://github.com/apache/spark/commit/3375bf4e0413954d672f65f494a8c7298c77c599).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735527308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735522606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735538981
**[Test build #131959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131959/testReport)** for PR 30539 at commit [`4335540`](https://github.com/apache/spark/commit/43355407b98aa5b89b4fe76889606bb51bf92733).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735527308
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735527141
**[Test build #131950 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131950/testReport)** for PR 30539 at commit [`527ec1a`](https://github.com/apache/spark/commit/527ec1afe362319fe0272ad1564c3ab0118cc374).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735539216
**[Test build #131959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131959/testReport)** for PR 30539 at commit [`4335540`](https://github.com/apache/spark/commit/43355407b98aa5b89b4fe76889606bb51bf92733).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] WeichenXu123 commented on a change in pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
WeichenXu123 commented on a change in pull request #30539:
URL: https://github.com/apache/spark/pull/30539#discussion_r532331686
##########
File path: python/pyspark/ml/tests/test_tuning.py
##########
@@ -401,6 +403,11 @@ def test_save_load_pipeline_estimator(self):
estimatorParamMaps=paramGrid,
evaluator=MulticlassClassificationEvaluator(),
numFolds=2) # use 3+ folds in practice
+ cvPath = temp_path + "/cv"
+ crossval.save(cvPath)
+ loadedCV = CrossValidator.load(cvPath)
+ self.assertEqual(len(loadedCV.getEstimatorParamMaps()), len(paramGrid))
+ self.assertEqual(loadedCV.getEstimator().uid, crossval.getEstimator().uid)
Review comment:
added test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735727291
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735785922
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735757227
**[Test build #131982 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131982/testReport)** for PR 30539 at commit [`f41bd69`](https://github.com/apache/spark/commit/f41bd69e48d366fd7cfaeda1a879bfe6bda05452).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735511083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735538981
**[Test build #131959 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131959/testReport)** for PR 30539 at commit [`4335540`](https://github.com/apache/spark/commit/43355407b98aa5b89b4fe76889606bb51bf92733).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735642271
**[Test build #131976 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131976/testReport)** for PR 30539 at commit [`b1c94cb`](https://github.com/apache/spark/commit/b1c94cbee7541ce9c44c0d2e54072df9c5ba2fff).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735580871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735522606
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735536330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735522990
**[Test build #131950 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131950/testReport)** for PR 30539 at commit [`527ec1a`](https://github.com/apache/spark/commit/527ec1afe362319fe0272ad1564c3ab0118cc374).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735510854
**[Test build #131946 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131946/testReport)** for PR 30539 at commit [`bbe3574`](https://github.com/apache/spark/commit/bbe357423fd328b44a9cf6cd8575d4e4a78c870b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735511083
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #30539:
URL: https://github.com/apache/spark/pull/30539
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735854073
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator writer lost params in estimatorParamMaps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735539225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30539:
URL: https://github.com/apache/spark/pull/30539#issuecomment-735606294
**[Test build #131960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131960/testReport)** for PR 30539 at commit [`3375bf4`](https://github.com/apache/spark/commit/3375bf4e0413954d672f65f494a8c7298c77c599).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a change in pull request #30539: [SPARK-33592] Fix: Pyspark ML Validator params in estimatorParamMaps may be lost after saving and reloading
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on a change in pull request #30539:
URL: https://github.com/apache/spark/pull/30539#discussion_r532358634
##########
File path: dev/sparktestsupport/modules.py
##########
@@ -564,6 +564,7 @@ def __hash__(self):
"pyspark.ml.tests.test_stat",
"pyspark.ml.tests.test_training_summary",
"pyspark.ml.tests.test_tuning",
+ "pyspark.ml.tests.test_util"
Review comment:
nit, ',' is missing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org