[GitHub] [shardingsphere] sandynz commented on a diff in pull request #19455: Remove TaskConfiguration reference from PrepareTargetSchemasParameter…

[GitBox <gi...@apache.org>]

sandynz commented on code in PR #19455:
URL: https://github.com/apache/shardingsphere/pull/19455#discussion_r927246479


##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/prepare/datasource/PrepareTargetSchemasParameter.java:
##########
@@ -30,7 +30,7 @@
 @Getter
 public final class PrepareTargetSchemasParameter {
     
-    private final TaskConfiguration taskConfig;
+    private final RuleAlteredJobConfiguration jobConfig;
     

Review Comment:
   It's better not depend on RuleAlteredJobConfiguration, since it's dedicated for a type of job. PrepareTargetSchemasParameter is planned for common usage (it might be used by several types of jobs).
   
   For example:
   - Add logicTableNames in PrepareTargetSchemasParameter to replace parameter.getJobConfig().splitLogicTableNames()
   - Extract sourceDatabaseType.isSchemaAvailable() to RuleAlteredJobPreparer
   
   And also PrepareTargetTablesParameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org