You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by ut...@apache.org on 2021/11/01 18:41:46 UTC

[mynewt-artifact] branch master updated: Remove ec256 ASN1 signature padding

This is an automated email from the ASF dual-hosted git repository.

utzig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-artifact.git


The following commit(s) were added to refs/heads/master by this push:
     new dc6549f  Remove ec256 ASN1 signature padding
dc6549f is described below

commit dc6549f643c5d6ec666d49b238094991dd0174a8
Author: Fabio Utzig <ut...@apache.org>
AuthorDate: Sun Oct 31 10:57:23 2021 -0300

    Remove ec256 ASN1 signature padding
    
    Old MCUboot releases required the ASN1 of ec256 signatures to be padded;
    this was removed with:
    
    https://github.com/mcu-tools/mcuboot/pull/680
    
    After this change, it is possible to build EC-256 based signature
    validation using Mbed TLS. This commit removes the padding and should
    allow following releases to use Mbed TLS, instead of Tinycrypt.
    
    Signed-off-by: Fabio Utzig <ut...@apache.org>
---
 image/create.go | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/image/create.go b/image/create.go
index 0217f2c..82fd1c8 100644
--- a/image/create.go
+++ b/image/create.go
@@ -224,9 +224,6 @@ func GenerateSigEc(key sec.PrivSignKey, hash []byte) ([]byte, error) {
 		return nil, errors.Errorf("signature truncated")
 	}
 
-	pad := make([]byte, int(sigLen)-len(signature))
-	signature = append(signature, pad...)
-
 	return signature, nil
 }