You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2019/03/12 22:36:52 UTC
[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12733
Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures
......................................................................
IMPALA-8303: Generate JUnitXML for ASAN failures
This modifies bin/jenkins/finalize.sh to detect ASAN error messages.
ASAN messages appear in the ERROR logs for impalad and in
logs/be_tests/LastTest.log for backend tests. This checks both
locations for "ERROR: AddressSanitizer:" messages.
Testing:
- Ran a Jenkins job with a known backend ASAN problem
- Ran finalize.sh on logs from an impalad ASAN crash
Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
---
M bin/jenkins/finalize.sh
1 file changed, 27 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/12733/1
--
To view, visit http://gerrit.cloudera.org:8080/12733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12733 )
Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2420/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Mar 2019 23:19:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12733 )
Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:25:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12733 )
Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 22:54:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12733 )
Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures
......................................................................
IMPALA-8303: Generate JUnitXML for ASAN failures
This modifies bin/jenkins/finalize.sh to detect ASAN error messages.
ASAN messages appear in the ERROR logs for impalad and in
logs/be_tests/LastTest.log for backend tests. This checks both
locations for "ERROR: AddressSanitizer:" messages.
Testing:
- Ran a Jenkins job with a known backend ASAN problem
- Ran finalize.sh on logs from an impalad ASAN crash
Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Reviewed-on: http://gerrit.cloudera.org:8080/12733
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/jenkins/finalize.sh
1 file changed, 27 insertions(+), 0 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-8303: Generate JUnitXML for ASAN failures
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12733 )
Change subject: IMPALA-8303: Generate JUnitXML for ASAN failures
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3905/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/12733
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5434703a02617d62dc0ed401b8cc1bf7a198a84d
Gerrit-Change-Number: 12733
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Mar 2019 18:28:50 +0000
Gerrit-HasComments: No