[GitHub] [iotdb] wangchao316 commented on a change in pull request #2874: [IOTDB-#2679] add "Clean the tracing log" of creating PR

[GitBox <gi...@apache.org>]

wangchao316 commented on a change in pull request #2874:
URL: https://github.com/apache/iotdb/pull/2874#discussion_r598085942



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/SqlBase.g4
##########
@@ -84,6 +84,7 @@ statement
     | KILL QUERY INT? #killQuery
     | TRACING ON #tracingOn
     | TRACING OFF #tracingOff
+    | TRACING CLEAR ALL #tracingClearAll

Review comment:
       hi , thanks for your contribution.
   you need add some UT or IT for your function.
   Thanks

##########
File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
##########
@@ -1309,6 +1311,21 @@ public boolean isEnablePerformanceTracing() {
 
   public void setEnablePerformanceTracing(boolean enablePerformanceTracing) {
     this.enablePerformanceTracing = enablePerformanceTracing;
+    if (!enablePerformanceTracing) {
+      try {
+        TracingManager.getInstance().close();

Review comment:
       generate a class only do a thing.  IoTDBConfig only get or set config.. if you need deal other logic, you can do it in other class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org