[jira] [Commented] (SLING-3485) Expose JSON Servlet Helpers

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13999707#comment-13999707 ] 

Carsten Ziegeler commented on SLING-3485:
-----------------------------------------

Basically the patch is fine, however instead of having the dependencies marked as optional, the package imports need to be marked as optional - or even better as dynamic. In addition a package export statement for the new package is missing.
But I can help with these things once you have the basic stuff committed.

I also think that we should have a look at the API and see if it might need improvements/changes

> Expose JSON Servlet Helpers
> ---------------------------
>
>                 Key: SLING-3485
>                 URL: https://issues.apache.org/jira/browse/SLING-3485
>             Project: Sling
>          Issue Type: Improvement
>          Components: Servlets
>    Affects Versions: Servlets Get 2.1.8
>            Reporter: Dan Klco
>            Priority: Minor
>              Labels: easyfix, patch
>         Attachments: SLING-3485.diff
>
>
> Right now the following classes which are used for the JsonRendererServletare not exported from the bundle.  From a developer's perspective, I may want to use these classes to remix the Resource -> JSON functionality without having to re-write the code.
> - https://svn.apache.org/repos/asf/sling/trunk/bundles/servlets/get/src/main/java/org/apache/sling/servlets/get/impl/helpers/JsonObjectCreator.java
> - https://svn.apache.org/repos/asf/sling/trunk/bundles/servlets/get/src/main/java/org/apache/sling/servlets/get/impl/helpers/ResourceTraversor.java
> I propose we refactor these classes to be in the package org.apache.sling.servlets.get.helpers which will expose them to the OSGi Container.



--
This message was sent by Atlassian JIRA
(v6.2#6252)