You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/25 19:05:23 UTC

[GitHub] [pulsar] tjiuming opened a new pull request, #15790: [doc][broker][monitoring] add message_ack_rate metric doc

tjiuming opened a new pull request, #15790:
URL: https://github.com/apache/pulsar/pull/15790

   ### Motivation
   
   doc for https://github.com/apache/pulsar/pull/15674
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [ ] `no-need-doc` 
   (Please explain why)
     
   - [x] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-added`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r896295511


##########
site2/docs/reference-metrics.md:
##########
@@ -220,6 +221,7 @@ All the topic metrics are labelled with the following labels:
 | pulsar_publish_rate_limit_times | Gauge | The number of times the publish rate limit is triggered. |
 | pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the topic coming into this broker  (message per second). |

Review Comment:
   OK. My suggestion is to use "connected to" rather than "coming into", following the description of `pulsar_consumers_count`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#issuecomment-1173242568

   These checks are skipped, can I merge this PR? @tjiuming 
   <img width="1126" alt="image" src="https://user-images.githubusercontent.com/50226895/177066630-9a6a2ee7-0232-4cd5-8955-66908d31cdb9.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#issuecomment-1138100511

   @tjiuming:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r895333678


##########
site2/docs/reference-metrics.md:
##########
@@ -220,6 +221,7 @@ All the topic metrics are labelled with the following labels:
 | pulsar_publish_rate_limit_times | Gauge | The number of times the publish rate limit is triggered. |
 | pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the topic coming into this broker  (message per second). |

Review Comment:
   ```suggestion
   | pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledgment rate of the topic coming into this broker (message per second). |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r895334334


##########
site2/docs/reference-metrics.md:
##########
@@ -220,6 +221,7 @@ All the topic metrics are labelled with the following labels:
 | pulsar_publish_rate_limit_times | Gauge | The number of times the publish rate limit is triggered. |
 | pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the topic coming into this broker  (message per second). |

Review Comment:
   Is it a rate of a namespace or a topic? The subject is different between Line175 and Line224.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tjiuming commented on pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#issuecomment-1172867775

   @Anonymitaet Please help merge the PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tjiuming commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
tjiuming commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r895882588


##########
site2/docs/reference-metrics.md:
##########
@@ -220,6 +221,7 @@ All the topic metrics are labelled with the following labels:
 | pulsar_publish_rate_limit_times | Gauge | The number of times the publish rate limit is triggered. |
 | pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the topic coming into this broker  (message per second). |

Review Comment:
   @momo-jun both of and topic and namespace, it's in different level



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] tjiuming commented on pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
tjiuming commented on PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#issuecomment-1173345663

   > These checks are skipped, can I merge this PR? @tjiuming <img alt="image" width="1126" src="https://user-images.githubusercontent.com/50226895/177066630-9a6a2ee7-0232-4cd5-8955-66908d31cdb9.png">
   
   All the required CI checks passed, I believe it's able to merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r895333678


##########
site2/docs/reference-metrics.md:
##########
@@ -220,6 +221,7 @@ All the topic metrics are labelled with the following labels:
 | pulsar_publish_rate_limit_times | Gauge | The number of times the publish rate limit is triggered. |
 | pulsar_throughput_in | Gauge | The total throughput of the topic coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the topic going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the topic coming into this broker  (message per second). |

Review Comment:
   ```suggestion
   | pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledgment rate of the topic coming into this broker  (message per second). |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet merged pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #15790:
URL: https://github.com/apache/pulsar/pull/15790


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r896295828


##########
site2/docs/reference-metrics.md:
##########
@@ -172,6 +172,7 @@ All the namespace metrics are labelled with the following labels:
 | pulsar_rate_out | Gauge | The total message rate of the namespace going out from this broker (message per second). |
 | pulsar_throughput_in | Gauge | The total throughput of the namespace coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the namespace going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the namespace coming into this broker  (message per second). |

Review Comment:
   There are two spaces before `(`. Can you remove one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on code in PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#discussion_r895333516


##########
site2/docs/reference-metrics.md:
##########
@@ -172,6 +172,7 @@ All the namespace metrics are labelled with the following labels:
 | pulsar_rate_out | Gauge | The total message rate of the namespace going out from this broker (message per second). |
 | pulsar_throughput_in | Gauge | The total throughput of the namespace coming into this broker (byte per second). |
 | pulsar_throughput_out | Gauge | The total throughput of the namespace going out from this broker (byte per second). |
+| pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledge rate of the namespace coming into this broker  (message per second). |

Review Comment:
   ```suggestion
   | pulsar_consumer_msg_ack_rate | Gauge | The total message acknowledgment rate of the namespace owned by this broker  (message per second). |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] momo-jun commented on pull request #15790: [doc][broker][monitoring] add message_ack_rate metric doc

Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #15790:
URL: https://github.com/apache/pulsar/pull/15790#issuecomment-1155086830

   Ping @Anonymitaet.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org