You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 19:26:21 UTC
[GitHub] [arrow] boshek opened a new pull request #12435: ARROW-15679 [R] count should return an ungrouped dataframe
boshek opened a new pull request #12435:
URL: https://github.com/apache/arrow/pull/12435
This modifies the `count` binding to return a data frame that matches the input grouped state. A test was also added to catch this beahviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook commented on a change in pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#discussion_r810225571
##########
File path: r/R/dplyr-count.R
##########
@@ -25,12 +25,13 @@ count.arrow_dplyr_query <- function(x, ..., wt = NULL, sort = FALSE, name = NULL
}
out <- dplyr::tally(out, wt = {{ wt }}, sort = sort, name = name)
- # Restore original group vars
gv <- dplyr::group_vars(x)
- if (length(gv)) {
+ if (rlang::is_empty(gv)) {
Review comment:
Thanks for this! For rlang functions, we prefer to import them so we don't have to use `rlang::`. Could you please add `is_empty` in to the imported rlang functions in [`arrow-package.R`](https://github.com/apache/arrow/blob/ade1027c3f6711374c6ccccff5ce068e0476664d/r/R/arrow-package.R#L22-L26), remove the `rlang::` here, and run `devtools::document()`? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#issuecomment-1040704510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#issuecomment-1045496847
Benchmark runs are scheduled for baseline = ade1027c3f6711374c6ccccff5ce068e0476664d and contender = bec777d96970715907785dcbaba18bebc92d2f9e. bec777d96970715907785dcbaba18bebc92d2f9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/15176d0e86ff4648a33e938bd4ec13b5...f0b23ff4b4984b16ac0931d6adc8f390/)
[Finished :arrow_down:0.08% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3359e1efaa9948b3b423c20c02151f7e...5fd55ff4df564564905a39e266f0a3fc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eb1b6565ac0c453e8093023822458cdf...c45689445c3c43fe9698f5d9dc1fb78f/)
[Finished :arrow_down:0.0% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea87e6f9b1e043e8a2ef33043cb67b65...60958fbe9ddc4d7abbb6ad7c79b31792/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#issuecomment-1045496847
Benchmark runs are scheduled for baseline = ade1027c3f6711374c6ccccff5ce068e0476664d and contender = bec777d96970715907785dcbaba18bebc92d2f9e. bec777d96970715907785dcbaba18bebc92d2f9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/15176d0e86ff4648a33e938bd4ec13b5...f0b23ff4b4984b16ac0931d6adc8f390/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3359e1efaa9948b3b423c20c02151f7e...5fd55ff4df564564905a39e266f0a3fc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eb1b6565ac0c453e8093023822458cdf...c45689445c3c43fe9698f5d9dc1fb78f/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea87e6f9b1e043e8a2ef33043cb67b65...60958fbe9ddc4d7abbb6ad7c79b31792/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#issuecomment-1045496847
Benchmark runs are scheduled for baseline = ade1027c3f6711374c6ccccff5ce068e0476664d and contender = bec777d96970715907785dcbaba18bebc92d2f9e. bec777d96970715907785dcbaba18bebc92d2f9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/15176d0e86ff4648a33e938bd4ec13b5...f0b23ff4b4984b16ac0931d6adc8f390/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3359e1efaa9948b3b423c20c02151f7e...5fd55ff4df564564905a39e266f0a3fc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eb1b6565ac0c453e8093023822458cdf...c45689445c3c43fe9698f5d9dc1fb78f/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea87e6f9b1e043e8a2ef33043cb67b65...60958fbe9ddc4d7abbb6ad7c79b31792/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ianmcook closed pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ianmcook closed pull request #12435:
URL: https://github.com/apache/arrow/pull/12435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#issuecomment-1045496847
Benchmark runs are scheduled for baseline = ade1027c3f6711374c6ccccff5ce068e0476664d and contender = bec777d96970715907785dcbaba18bebc92d2f9e. bec777d96970715907785dcbaba18bebc92d2f9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/15176d0e86ff4648a33e938bd4ec13b5...f0b23ff4b4984b16ac0931d6adc8f390/)
[Finished :arrow_down:0.08% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3359e1efaa9948b3b423c20c02151f7e...5fd55ff4df564564905a39e266f0a3fc/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eb1b6565ac0c453e8093023822458cdf...c45689445c3c43fe9698f5d9dc1fb78f/)
[Finished :arrow_down:0.0% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea87e6f9b1e043e8a2ef33043cb67b65...60958fbe9ddc4d7abbb6ad7c79b31792/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#issuecomment-1045496847
Benchmark runs are scheduled for baseline = ade1027c3f6711374c6ccccff5ce068e0476664d and contender = bec777d96970715907785dcbaba18bebc92d2f9e. bec777d96970715907785dcbaba18bebc92d2f9e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/15176d0e86ff4648a33e938bd4ec13b5...f0b23ff4b4984b16ac0931d6adc8f390/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/3359e1efaa9948b3b423c20c02151f7e...5fd55ff4df564564905a39e266f0a3fc/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/eb1b6565ac0c453e8093023822458cdf...c45689445c3c43fe9698f5d9dc1fb78f/)
[Finished :arrow_down:0.0% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea87e6f9b1e043e8a2ef33043cb67b65...60958fbe9ddc4d7abbb6ad7c79b31792/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] boshek commented on a change in pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe
Posted by GitBox <gi...@apache.org>.
boshek commented on a change in pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#discussion_r810385764
##########
File path: r/R/dplyr-count.R
##########
@@ -25,12 +25,13 @@ count.arrow_dplyr_query <- function(x, ..., wt = NULL, sort = FALSE, name = NULL
}
out <- dplyr::tally(out, wt = {{ wt }}, sort = sort, name = name)
- # Restore original group vars
gv <- dplyr::group_vars(x)
- if (length(gv)) {
+ if (rlang::is_empty(gv)) {
Review comment:
That makes sense. Thanks for the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org