You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Pavel Moravec (JIRA)" <ji...@apache.org> on 2011/08/22 16:26:29 UTC

[jira] [Created] (QPID-3447) Creating invalid federation link causes file descriptor leak

Creating invalid federation link causes file descriptor leak
------------------------------------------------------------

                 Key: QPID-3447
                 URL: https://issues.apache.org/jira/browse/QPID-3447
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker
    Affects Versions: 0.10
            Reporter: Pavel Moravec


Specifying invalid IP address of destination broker causes repeatable file
descriptor leak.

Steps to Reproduce:
1. qpid-route -v link add localhost 10:17700
(alternativelly, create a dynamic route like    qpid-route dynamic add localhost 10:17700 amq.direct )
2. lsof -p $(pgrep qpidd) | grep "can't identify protocol"

Since then, lsof will show "can't identify protocol" file descriptors whose number is increasing in time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Commented] (QPID-3447) Creating invalid federation link causes file descriptor leak

Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089061#comment-13089061 ] 

Andrew Stitcher commented on QPID-3447:
---------------------------------------

Note the attached fix is not the fix that was applied as it only ameliorates the symptom of running out of file handles rather than fixing the underlying Socket leak.

> Creating invalid federation link causes file descriptor leak
> ------------------------------------------------------------
>
>                 Key: QPID-3447
>                 URL: https://issues.apache.org/jira/browse/QPID-3447
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.10
>            Reporter: Pavel Moravec
>            Assignee: Andrew Stitcher
>              Labels: patch
>             Fix For: 0.13
>
>         Attachments: fd_leak.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Specifying invalid IP address of destination broker causes repeatable file
> descriptor leak.
> Steps to Reproduce:
> 1. qpid-route -v link add localhost 10:17700
> (alternativelly, create a dynamic route like    qpid-route dynamic add localhost 10:17700 amq.direct )
> 2. lsof -p $(pgrep qpidd) | grep "can't identify protocol"
> Since then, lsof will show "can't identify protocol" file descriptors whose number is increasing in time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Resolved] (QPID-3447) Creating invalid federation link causes file descriptor leak

Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Stitcher resolved QPID-3447.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.13

> Creating invalid federation link causes file descriptor leak
> ------------------------------------------------------------
>
>                 Key: QPID-3447
>                 URL: https://issues.apache.org/jira/browse/QPID-3447
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.10
>            Reporter: Pavel Moravec
>            Assignee: Andrew Stitcher
>              Labels: patch
>             Fix For: 0.13
>
>         Attachments: fd_leak.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Specifying invalid IP address of destination broker causes repeatable file
> descriptor leak.
> Steps to Reproduce:
> 1. qpid-route -v link add localhost 10:17700
> (alternativelly, create a dynamic route like    qpid-route dynamic add localhost 10:17700 amq.direct )
> 2. lsof -p $(pgrep qpidd) | grep "can't identify protocol"
> Since then, lsof will show "can't identify protocol" file descriptors whose number is increasing in time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3447) Creating invalid federation link causes file descriptor leak

Posted by "Pavel Moravec (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pavel Moravec updated QPID-3447:
--------------------------------

    Attachment: fd_leak.patch

Patch proposal.

The root cause of the FD leak is missing Socket::close() method when ::connect method returns negative (i.e. connection fails).

Patch adds the close method invocation plus logs the failure via QPID_LOG.

> Creating invalid federation link causes file descriptor leak
> ------------------------------------------------------------
>
>                 Key: QPID-3447
>                 URL: https://issues.apache.org/jira/browse/QPID-3447
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.10
>            Reporter: Pavel Moravec
>              Labels: patch
>         Attachments: fd_leak.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Specifying invalid IP address of destination broker causes repeatable file
> descriptor leak.
> Steps to Reproduce:
> 1. qpid-route -v link add localhost 10:17700
> (alternativelly, create a dynamic route like    qpid-route dynamic add localhost 10:17700 amq.direct )
> 2. lsof -p $(pgrep qpidd) | grep "can't identify protocol"
> Since then, lsof will show "can't identify protocol" file descriptors whose number is increasing in time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3447) Creating invalid federation link causes file descriptor leak

Posted by "Andrew Stitcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Stitcher reassigned QPID-3447:
-------------------------------------

    Assignee: Andrew Stitcher

> Creating invalid federation link causes file descriptor leak
> ------------------------------------------------------------
>
>                 Key: QPID-3447
>                 URL: https://issues.apache.org/jira/browse/QPID-3447
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.10
>            Reporter: Pavel Moravec
>            Assignee: Andrew Stitcher
>              Labels: patch
>         Attachments: fd_leak.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Specifying invalid IP address of destination broker causes repeatable file
> descriptor leak.
> Steps to Reproduce:
> 1. qpid-route -v link add localhost 10:17700
> (alternativelly, create a dynamic route like    qpid-route dynamic add localhost 10:17700 amq.direct )
> 2. lsof -p $(pgrep qpidd) | grep "can't identify protocol"
> Since then, lsof will show "can't identify protocol" file descriptors whose number is increasing in time.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org