You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by "nielsbasjes (via GitHub)" <gi...@apache.org> on 2023/02/06 16:00:09 UTC
[GitHub] [unomi] nielsbasjes opened a new pull request, #574: [UNOMI-722]: Update Yauaa to 7.12.0
nielsbasjes opened a new pull request, #574:
URL: https://github.com/apache/unomi/pull/574
Merge request https://github.com/apache/unomi/pull/557 introduced the need for an unexpected extra `<Import-Package>` setting because of a dependency of Yauaa.
In the just released version of Yauaa this should be fixed.
----
**Please** following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/UNOMI) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Format the pull request title like `[UNOMI-XXX] - Title of the pull request`
- [ ] Provide integration tests for your changes, especially if you are changing the behavior of existing code or adding
significant new parts of code.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Copy the description to the related JIRA issue
- [ ] Run `mvn clean install -P integration-tests` to make sure basic checks pass. A more thorough check will be
performed on your pull request automatically.
Trivial changes like typos do not require a JIRA issue (javadoc, project build changes, small doc changes, comments...).
If this is your first contribution, you have to read the [Contribution Guidelines](https://unomi.apache.org/contribute.html)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on pull request #574: [UNOMI-722]: Update Yauaa to 7.12.0
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan commented on PR #574:
URL: https://github.com/apache/unomi/pull/574#issuecomment-1429347180
Thx for the contribution again.
Is the PR available for review ? can you move it to review so we could merge it ? It's currently in draft.
(I rerun the tests that failed, I think it was a flaky run)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on pull request #574: [UNOMI-722]: Update Yauaa to 7.12.0
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan commented on PR #574:
URL: https://github.com/apache/unomi/pull/574#issuecomment-1429771906
Alright, yes the tests passed on the second run, so everything looks fine.
Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] nielsbasjes commented on pull request #574: [UNOMI-722]: Update Yauaa to 7.13.0
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #574:
URL: https://github.com/apache/unomi/pull/574#issuecomment-1432806367
@jkevan I've updated to the latest version and marked it ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on a diff in pull request #574: [UNOMI-722]: Update Yauaa to 7.13.0
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan commented on code in PR #574:
URL: https://github.com/apache/unomi/pull/574#discussion_r1116144338
##########
plugins/request/pom.xml:
##########
@@ -46,7 +46,7 @@
<dependency>
<groupId>nl.basjes.parse.useragent</groupId>
<artifactId>yauaa</artifactId>
- <version>7.11.0</version>
+ <version>7.12.0</version>
Review Comment:
Shouldn't be 7.13.0 version here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] nielsbasjes commented on a diff in pull request #574: [UNOMI-722]: Update Yauaa to 7.13.0
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on code in PR #574:
URL: https://github.com/apache/unomi/pull/574#discussion_r1116153563
##########
plugins/request/pom.xml:
##########
@@ -46,7 +46,7 @@
<dependency>
<groupId>nl.basjes.parse.useragent</groupId>
<artifactId>yauaa</artifactId>
- <version>7.11.0</version>
+ <version>7.12.0</version>
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] nielsbasjes commented on a diff in pull request #574: [UNOMI-722]: Update Yauaa to 7.13.0
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on code in PR #574:
URL: https://github.com/apache/unomi/pull/574#discussion_r1116198483
##########
plugins/request/pom.xml:
##########
@@ -46,7 +46,7 @@
<dependency>
<groupId>nl.basjes.parse.useragent</groupId>
<artifactId>yauaa</artifactId>
- <version>7.11.0</version>
+ <version>7.12.0</version>
Review Comment:
Sorry about that. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on pull request #574: [UNOMI-722]: Update Yauaa to 7.13.0
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan commented on PR #574:
URL: https://github.com/apache/unomi/pull/574#issuecomment-1443234939
Thanks for contributing the update of the lib.
Best regards.
I will merge it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan merged pull request #574: [UNOMI-722]: Update Yauaa to 7.13.0
Posted by "jkevan (via GitHub)" <gi...@apache.org>.
jkevan merged PR #574:
URL: https://github.com/apache/unomi/pull/574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] nielsbasjes commented on pull request #574: [UNOMI-722]: Update Yauaa to 7.12.0
Posted by "nielsbasjes (via GitHub)" <gi...@apache.org>.
nielsbasjes commented on PR #574:
URL: https://github.com/apache/unomi/pull/574#issuecomment-1429722887
> Thx for the contribution again. Is the PR available for review ?
I released a new version yesterday. Received a few more edge cases today that I want to fix.
As soon as I have that in I'll update it.
> can you move it to review so we could merge it ? It's currently in draft.
I know, I put it in draft because I was unsure if it would pass the build ... and then it didn't.
Yes, I will put it in ready for review do when ready.
> (I rerun the tests that failed, I think it was a flaky run)
Aha, that explains it. I completely did not understand what caused the CI run to fail. I went looking what I did wrong and couldn't figure it out.
Thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org