Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

[David Mollitor <da...@gmail.com>]

> On Nov. 22, 2021, 10:35 p.m., Abhishek  Kumar wrote:
> > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
> > Lines 919 (patched)
> > <https://reviews.apache.org/r/73677/diff/1/?file=2254818#file2254818line919>
> >
> >     Why is max required here ?
> 
> David Mollitor wrote:
>     Hello, I am not sure, but this was the behavior of the original code and I did not want to change behavior in this way for this particular issue.

Any additional questions or thoughts on this matter?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73677/#review223761
-----------------------------------------------------------


On Nov. 22, 2021, 9:40 p.m., David Mollitor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73677/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2021, 9:40 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3285: Off-By-One Error in XUser Syncing
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 60445043f 
> 
> 
> Diff: https://reviews.apache.org/r/73677/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Mollitor
> 
>