You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jolshan (via GitHub)" <gi...@apache.org> on 2023/03/28 22:46:23 UTC

[GitHub] [kafka] jolshan opened a new pull request, #13469: MINOR: Remove addOne to fix build

jolshan opened a new pull request, #13469:
URL: https://github.com/apache/kafka/pull/13469

   https://github.com/apache/kafka/commit/f1b3732fa64372327377834954561d2e63e7d2ce broke the build
   
   [2023-03-28T17:49:54.909Z] [Error] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13463/core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala:436:50: value addOne is not a member of scala.collection.mutable.ArrayBuffer[scala.collection.mutable.Buffer[org.apache.kafka.server.common.ApiMessageAndVersion]]
   
   Removed the offending method
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on a diff in pull request #13469: MINOR: Remove addOne to fix build

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #13469:
URL: https://github.com/apache/kafka/pull/13469#discussion_r1152191775


##########
core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala:
##########
@@ -433,7 +433,7 @@ class ZkMigrationClientTest extends QuorumTestHarness {
   def migrateAclsAndVerify(authorizer: AclAuthorizer, acls: Seq[AclBinding]): Unit = {
     authorizer.createAcls(null, acls.asJava)
     val batches = new ArrayBuffer[mutable.Buffer[ApiMessageAndVersion]]()
-    migrationClient.migrateAcls(batch => batches.addOne(batch.asScala))
+    migrationClient.migrateAcls(batch => batches ++ batch.asScala)

Review Comment:
   I didn't see append before, but let's try it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #13469: MINOR: Remove addOne to fix build

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #13469:
URL: https://github.com/apache/kafka/pull/13469#issuecomment-1487731429

   ^ Looks like this got tied to someone's auto reply somehow 😅 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan merged pull request #13469: MINOR: Remove addOne to fix build

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #13469:
URL: https://github.com/apache/kafka/pull/13469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] 1845725202 commented on pull request #13469: MINOR: Remove addOne to fix build

Posted by "1845725202 (via GitHub)" <gi...@apache.org>.
1845725202 commented on PR #13469:
URL: https://github.com/apache/kafka/pull/13469#issuecomment-1487724216

   这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mumrah commented on a diff in pull request #13469: MINOR: Remove addOne to fix build

Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #13469:
URL: https://github.com/apache/kafka/pull/13469#discussion_r1152189688


##########
core/src/test/scala/unit/kafka/zk/ZkMigrationClientTest.scala:
##########
@@ -433,7 +433,7 @@ class ZkMigrationClientTest extends QuorumTestHarness {
   def migrateAclsAndVerify(authorizer: AclAuthorizer, acls: Seq[AclBinding]): Unit = {
     authorizer.createAcls(null, acls.asJava)
     val batches = new ArrayBuffer[mutable.Buffer[ApiMessageAndVersion]]()
-    migrationClient.migrateAcls(batch => batches.addOne(batch.asScala))
+    migrationClient.migrateAcls(batch => batches ++ batch.asScala)

Review Comment:
   ```suggestion
       migrationClient.migrateAcls(batch => batches.append(batch.asScala))
   ```
   
   `++` is basically creating a new buffer here rather than adding to `batches`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jolshan commented on pull request #13469: MINOR: Remove addOne to fix build

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on PR #13469:
URL: https://github.com/apache/kafka/pull/13469#issuecomment-1487893570

   Test seems to be failing. I will need to do a different fix. (I thought it was passing locally, but seems not)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org