[GitHub] [zookeeper] maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255

[GitBox <gi...@apache.org>]

maoling commented on issue #832: ZOOKEEPER-2503:do a hard constraints on the number of myid which must be between 1 and 255
URL: https://github.com/apache/zookeeper/pull/832#issuecomment-474186545
 
 
   - @lvfangmin the `validateServerId` logic in `EphemeralType` is not a good place.
         e.g if the server which `myid=255` and her role is not the leader,it can create the ttl node normally and 
     throw any exceptions. Really an issue. all logics which judge the myid should be put in the start up of the server,I will fix this.
   - @phunt extend myid to 0, because 0 is also a valid number. lots of unit tests use the myid=0, some of them are complicated.(e.g. assert the myid of the leader). it cannot just use `i+1` to pass these tests. A headache,just do this to make jenkins happy.
   Cc @anmolnar @eolivelli @Randgalt 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services