[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #48: docs: add usage/design/install/contribute/FAQ docs & modify README

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #48:
URL: https://github.com/apache/apisix-ingress-controller/pull/48#discussion_r537982915



##########
File path: samples/deploy/rbac/apisix_view_clusterrolebinding.yaml
##########
@@ -8,5 +8,4 @@ roleRef:
   name: apisix-view-clusterrole
 subjects:
 - kind: ServiceAccount
-  name: apisix-view-serviceaccount
-  namespace: cloud
\ No newline at end of file
+  name: apisix-view-serviceaccount

Review comment:
       need a blank line at the end of file

##########
File path: samples/deploy/rbac/service_account.yaml
##########
@@ -2,4 +2,4 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: apisix-view-serviceaccount
-  namespace: cloud
\ No newline at end of file
+  

Review comment:
       ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org