You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/06/12 17:29:13 UTC

[GitHub] [activemq-artemis] avi5kdonrh opened a new pull request #3181: ARTEMIS-2804 Human readable timestamp is incorrectly parsed in web console

avi5kdonrh opened a new pull request #3181:
URL: https://github.com/apache/activemq-artemis/pull/3181


   The web console displays the day of the week instead of the day of the month in the timestamp column while browsing a queue from the web console. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jbertram commented on pull request #3181: ARTEMIS-2804 Human readable timestamp is incorrectly parsed in web console

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3181:
URL: https://github.com/apache/activemq-artemis/pull/3181#issuecomment-644261143


   @avi5kdonrh, can you update the commit message to follow [the pattern outlined in the hacking guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/code.md#commitMessageDetails)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] asfgit closed pull request #3181: ARTEMIS-2804 Human readable timestamp is incorrectly parsed in web console

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3181:
URL: https://github.com/apache/activemq-artemis/pull/3181


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jbertram commented on pull request #3181: ARTEMIS-2804 Human readable timestamp is incorrectly parsed in web console

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3181:
URL: https://github.com/apache/activemq-artemis/pull/3181#issuecomment-644265280


   @avi5kdonrh, don't worry about the commit message. I fixed it during merge. Thanks for the fix!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] avi5kdonrh commented on pull request #3181: ARTEMIS-2804 Human readable timestamp is incorrectly parsed in web console

Posted by GitBox <gi...@apache.org>.
avi5kdonrh commented on pull request #3181:
URL: https://github.com/apache/activemq-artemis/pull/3181#issuecomment-644266942


   @jbertram, @franz1981  Thank you very much. Next time I'll keep the guidelines in mind.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] jbertram commented on pull request #3181: ARTEMIS-2804 Human readable timestamp is incorrectly parsed in web console

Posted by GitBox <gi...@apache.org>.
jbertram commented on pull request #3181:
URL: https://github.com/apache/activemq-artemis/pull/3181#issuecomment-643649328


   The commits should be squashed and the comment should be removed and added to the commit message as it only makes sense in the context of the change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org