[shardingsphere-elasticjob] branch master updated: Add more test for SnapshotService (#1428) (#1429)

[te...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git


The following commit(s) were added to refs/heads/master by this push:
     new bbba2a3  Add more test for SnapshotService (#1428) (#1429)
bbba2a3 is described below

commit bbba2a3c509de70696a78916fe2072fe758cc6a3
Author: Tboy <gu...@immomo.com>
AuthorDate: Mon Aug 31 10:03:29 2020 +0800

    Add more test for SnapshotService (#1428) (#1429)
---
 .../internal/snapshot/BaseSnapshotServiceTest.java |  1 +
 .../snapshot/SnapshotServiceDisableTest.java       | 23 ++++++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/BaseSnapshotServiceTest.java b/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/BaseSnapshotServiceTest.java
index 0a8fae5..b3568b3 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/BaseSnapshotServiceTest.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/BaseSnapshotServiceTest.java
@@ -38,6 +38,7 @@ public abstract class BaseSnapshotServiceTest {
     
     private static final ZookeeperConfiguration ZOOKEEPER_CONFIG = new ZookeeperConfiguration(EmbedTestingServer.getConnectionString(), "zkRegTestCenter");
     
+    @Getter(value = AccessLevel.PROTECTED)
     private static final CoordinatorRegistryCenter REG_CENTER = new ZookeeperRegistryCenter(ZOOKEEPER_CONFIG);
     
     @Getter(value = AccessLevel.PROTECTED)
diff --git a/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/SnapshotServiceDisableTest.java b/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/SnapshotServiceDisableTest.java
index 7f6e618..d136509 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/SnapshotServiceDisableTest.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/test/java/org/apache/shardingsphere/elasticjob/lite/internal/snapshot/SnapshotServiceDisableTest.java
@@ -17,10 +17,15 @@
 
 package org.apache.shardingsphere.elasticjob.lite.internal.snapshot;
 
+import lombok.SneakyThrows;
 import org.apache.shardingsphere.elasticjob.lite.fixture.job.DetailedFooJob;
 import org.junit.Test;
 
 import java.io.IOException;
+import java.lang.reflect.Field;
+import java.net.ServerSocket;
+
+import static org.junit.Assert.assertNull;
 
 public final class SnapshotServiceDisableTest extends BaseSnapshotServiceTest {
     
@@ -32,4 +37,22 @@ public final class SnapshotServiceDisableTest extends BaseSnapshotServiceTest {
     public void assertMonitorWithDumpCommand() throws IOException {
         SocketUtils.sendCommand(SnapshotService.DUMP_COMMAND, DUMP_PORT - 1);
     }
+    
+    @Test(expected = RuntimeException.class)
+    public void assertPortInvalid() {
+        SnapshotService snapshotService = new SnapshotService(getREG_CENTER(), -1);
+        snapshotService.listen();
+    }
+    
+    @Test
+    @SneakyThrows
+    public void assertListenException() {
+        ServerSocket serverSocket = new ServerSocket(9898);
+        SnapshotService snapshotService = new SnapshotService(getREG_CENTER(), 9898);
+        snapshotService.listen();
+        serverSocket.close();
+        Field field = snapshotService.getClass().getDeclaredField("serverSocket");
+        field.setAccessible(true);
+        assertNull(field.get(snapshotService));
+    }
 }